You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/10 09:41:29 UTC

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1566: plugin grpc-transcode bugfix: got 500 error when using post method

spacewander commented on a change in pull request #1566:
URL: https://github.com/apache/incubator-apisix/pull/1566#discussion_r422618569



##########
File path: apisix/plugins/grpc-transcode/util.lua
##########
@@ -51,7 +51,7 @@ local function get_from_request(name, kind)
     local request_table
     if ngx.req.get_method() == "POST" then
         if string.find(ngx.req.get_headers()["Content-Type"] or "",
-                       "application/json", true) then
+                       "application/json") then

Review comment:
       Doesn't the original code mean `string.find(str, pattern, 1, true)`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org