You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2025/10/15 04:04:52 UTC

[PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Mryange opened a new pull request, #56984:
URL: https://github.com/apache/doris/pull/56984

   ### What problem does this PR solve?
   
   1. When executing cast, check the column and type of both input and output.
   2. PreparedFunctionCast will not be constructed repeatedly during execution; it will be saved during open.
   
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56984:
URL: https://github.com/apache/doris/pull/56984#issuecomment-4240467002

   We're closing this PR because it hasn't been updated in a while.
   This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #56984:
URL: https://github.com/apache/doris/pull/56984#issuecomment-3404433815

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #56984: [refine](cast) Check whether the input type in cast matches the one in the FE plan.
URL: https://github.com/apache/doris/pull/56984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56984:
URL: https://github.com/apache/doris/pull/56984#issuecomment-3405081535

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 190620 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit b871037a397a02ebcf96a41a5e741b32a11ca7fe, data reload: false
   
   query1	1057	433	401	401
   query2	6566	1705	1733	1705
   query3	6748	229	221	221
   query4	26274	23799	23671	23671
   query5	5348	682	480	480
   query6	315	236	212	212
   query7	4657	504	296	296
   query8	300	252	247	247
   query9	8736	2552	2538	2538
   query10	544	341	274	274
   query11	15546	15047	14964	14964
   query12	207	115	111	111
   query13	1672	538	447	447
   query14	11787	9492	9482	9482
   query15	209	206	184	184
   query16	7755	760	567	567
   query17	1497	819	653	653
   query18	2926	451	327	327
   query19	206	229	186	186
   query20	154	147	129	129
   query21	217	145	125	125
   query22	4749	4731	4652	4652
   query23	35114	33809	33558	33558
   query24	8669	2646	2506	2506
   query25	627	580	512	512
   query26	1289	294	168	168
   query27	2903	524	372	372
   query28	4494	2246	2205	2205
   query29	838	671	606	606
   query30	295	220	198	198
   query31	920	796	757	757
   query32	80	70	67	67
   query33	584	388	320	320
   query34	817	826	512	512
   query35	778	851	755	755
   query36	961	1012	941	941
   query37	120	110	78	78
   query38	3483	3580	3449	3449
   query39	1494	1435	1408	1408
   query40	216	126	115	115
   query41	63	59	61	59
   query42	126	114	127	114
   query43	488	498	472	472
   query44	1317	829	827	827
   query45	177	178	170	170
   query46	822	997	621	621
   query47	1754	1784	1710	1710
   query48	397	419	338	338
   query49	757	502	409	409
   query50	637	684	405	405
   query51	3893	3921	3893	3893
   query52	114	113	106	106
   query53	235	270	193	193
   query54	606	586	537	537
   query55	93	87	86	86
   query56	325	329	316	316
   query57	1167	1177	1131	1131
   query58	289	278	277	277
   query59	2514	2665	2517	2517
   query60	350	349	330	330
   query61	157	152	159	152
   query62	810	720	700	700
   query63	221	194	191	191
   query64	4431	1146	841	841
   query65	4031	3992	3975	3975
   query66	1067	433	356	356
   query67	15568	15259	14971	14971
   query68	8536	927	592	592
   query69	513	334	301	301
   query70	1415	1282	1321	1282
   query71	518	344	306	306
   query72	6043	4935	4935	4935
   query73	721	609	364	364
   query74	8849	8992	8994	8992
   query75	4100	3330	2797	2797
   query76	3763	1149	723	723
   query77	830	407	313	313
   query78	9602	9764	8873	8873
   query79	2370	840	596	596
   query80	638	563	510	510
   query81	499	269	229	229
   query82	434	156	134	134
   query83	293	271	253	253
   query84	304	113	92	92
   query85	943	498	443	443
   query86	339	322	300	300
   query87	3811	3822	3639	3639
   query88	3258	2239	2226	2226
   query89	396	335	291	291
   query90	2044	220	208	208
   query91	168	183	138	138
   query92	83	64	66	64
   query93	1521	990	638	638
   query94	699	493	305	305
   query95	407	307	311	307
   query96	487	586	285	285
   query97	2948	2987	2890	2890
   query98	244	214	211	211
   query99	1444	1415	1287	1287
   Total cold run time: 281781 ms
   Total hot run time: 190620 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #56984:
URL: https://github.com/apache/doris/pull/56984#issuecomment-3404517401

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #56984:
URL: https://github.com/apache/doris/pull/56984#issuecomment-3404939512

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refine](cast) Check whether the input type in cast matches the one in the FE plan. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56984:
URL: https://github.com/apache/doris/pull/56984#issuecomment-3405103178

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.46 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit b871037a397a02ebcf96a41a5e741b32a11ca7fe, data reload: false
   
   query1	0.06	0.05	0.05
   query2	0.09	0.06	0.06
   query3	0.25	0.08	0.08
   query4	1.60	0.12	0.12
   query5	0.27	0.26	0.26
   query6	1.18	0.66	0.64
   query7	0.03	0.03	0.03
   query8	0.06	0.05	0.05
   query9	0.62	0.53	0.53
   query10	0.58	0.60	0.58
   query11	0.16	0.12	0.11
   query12	0.15	0.12	0.12
   query13	0.64	0.62	0.62
   query14	1.01	1.02	1.01
   query15	0.85	0.86	0.87
   query16	0.42	0.39	0.40
   query17	1.05	1.02	1.07
   query18	0.21	0.20	0.20
   query19	1.86	1.84	1.88
   query20	0.02	0.01	0.01
   query21	15.46	0.95	0.57
   query22	0.75	1.24	0.70
   query23	14.84	1.36	0.68
   query24	6.80	1.87	0.83
   query25	0.42	0.21	0.13
   query26	0.69	0.15	0.12
   query27	0.06	0.05	0.06
   query28	9.29	1.36	0.93
   query29	12.63	3.90	3.24
   query30	0.29	0.13	0.12
   query31	2.83	0.59	0.39
   query32	3.25	0.55	0.48
   query33	3.03	3.03	3.14
   query34	16.25	5.40	4.82
   query35	4.94	4.97	4.92
   query36	0.69	0.50	0.50
   query37	0.10	0.07	0.07
   query38	0.06	0.05	0.04
   query39	0.04	0.03	0.03
   query40	0.18	0.15	0.15
   query41	0.09	0.03	0.02
   query42	0.04	0.03	0.03
   query43	0.04	0.03	0.03
   Total cold run time: 103.88 s
   Total hot run time: 30.46 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org