You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by xijianlv <gi...@git.apache.org> on 2017/06/13 08:04:48 UTC
[GitHub] nifi pull request #1913: NIFI-3603���Localization needed
GitHub user xijianlv opened a pull request:
https://github.com/apache/nifi/pull/1913
NIFI-3603：Localization needed
NIFI-3603：Localization needed
I have completed localization changes including Chinese and English, as well as Japanese part of the localized changes, only need
(1) in nifi-web-ui \ src \ main \ java add the local language properties file, and then specify it in web.xml
(2) Add an array of native languages to nifi-web-ui \ src \ main \ webapp \ js \ nf \ globalization \ resources.js and point the parameter locale to it
It can help NIFI developers around the world more convenient to use it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xijianlv/nifi-1 NIFI-3603
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1913.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1913
----
commit 2d0d09591263c0878f9c082637d6bbd7978b6c66
Author: WangJian <19...@qq.com>
Date: 2017-03-19T01:45:11Z
NIFI-3603:Updated nifi-web-ui POM to add localization files
commit abf1ed3cd63b89c06945273783c7826ba6d7f9c7
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:03:24Z
NIFI-3603:Updated WEB-INF to add jstl dependencies to the jsp files and the jstl configuration in web.xml
commit daa085203982d0b7d2fea71fd8856e23f5cc9839
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:12:27Z
Updated js directory to add *.js localized changes and add gloabalization directory
commit 2da95e0d39d03bb0ba2596c0733071b4ceb86992
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:13:53Z
Updated js directory to add *.js localized changes and add gloabalization directory
commit c55c9dfbe2761ac035ac6a5ae10161dda9d80331
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:13:53Z
NIFI-3603:Updated js directory to add *.js localized changes and add gloabalization directory
commit c28f28098d91e8181460661bebc9a1254f3c6c24
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:26:28Z
Merge branch 'NIFI-3603' of https://github.com/wangrenlei/nifi-1 into NIFI-3603
commit 216d4d84d67dba21ab76264c14ee1221c8c654dc
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:33:28Z
NIFI-3603:Add the *.properties file
commit 60492b13c10cbab667d3b3cc2e9aaacc2a2341a2
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:36:05Z
nothing
commit 5d1c68b7bde3c7601b3f4d411c14a00253bc0b05
Author: WangJian <19...@qq.com>
Date: 2017-03-19T02:38:36Z
NIFI-3603: Updated js directory to add *.js localized changes and add gloabalization directory
commit bae6684551b375abcba4d2079df0a59e479f5d49
Author: WangJian <19...@qq.com>
Date: 2017-03-19T03:09:09Z
Merge branch 'master' into NIFI-3603
commit 62cf46f9f50e75b346e1e6ecada85e27e6a60db2
Author: WangJian <19...@qq.com>
Date: 2017-03-20T09:31:40Z
NIFI-3603:add the apache license in localization files
commit 4189435d57926b46200570a3618a4e8fde3bac24
Author: WangJian <19...@qq.com>
Date: 2017-03-20T09:33:05Z
Merge branch 'NIFI-3603' of https://github.com/wangrenlei/nifi-1 into NIFI-3603
commit 1232ae728a21d2eb99a2a0070bbb487cd5cb6eff
Author: WangJian <19...@qq.com>
Date: 2017-03-20T10:38:32Z
NIFI-3603:Modified js error
commit fb9618ce09d06ed9109151d83deac84270c7dc71
Author: WangJian <19...@qq.com>
Date: 2017-03-21T02:07:14Z
NIFI-3603:Modified nf-process-group.js error
commit 78369684b793302864b72ac250ec2f7835066e4d
Author: WangJian <19...@qq.com>
Date: 2017-03-21T02:23:44Z
NIFI-3603:Modified port-configuration.jsp
commit 08007c1203aa44039141b0962219dfec511fe1ab
Author: WangJian <19...@qq.com>
Date: 2017-03-22T09:21:34Z
Merge branch 'master' into NIFI-3603
commit 7b3f456d19d50decb3f2d92ab3c35239a86446b0
Author: WangJian <19...@qq.com>
Date: 2017-03-22T09:40:55Z
NIFI-3603:Merge nf-remote-process-group-ports.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1913: NIFI-3603���Localization needed
Posted by tsingfu <gi...@git.apache.org>.
Github user tsingfu commented on the issue:
https://github.com/apache/nifi/pull/1913
@xijianlv @wangrenlei
I tried localization using jstl in this way on the master(1.5.0-SNAPSHORT), but encountered jstl error while access `http://xxx:8080/nifi`.
I googled many solution, but still failed to solve it, Could you give me any some advices?
Thanks.
NIFI_HOME/logs/nifi-app.log
```
2017-12-15 11:46:44,888 INFO [main] org.apache.nifi.BootstrapListener Successfully initiated communication with Bootstrap
2017-12-15 11:46:44,888 INFO [main] org.apache.nifi.NiFi Controller initialization took 14370843501 nanoseconds (14 seconds).
2017-12-15 11:47:10,627 WARN [NiFi Web Server-63] org.eclipse.jetty.server.HttpChannel /nifi/
javax.servlet.ServletException: org.apache.jasper.JasperException: The absolute uri: http://java.sun.com/jsp/jstl/fmt cannot be resolved in either web.xml or the jar files deployed with this application
at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:138)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:561)
at org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:52)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
at org.eclipse.jetty.server.Server.handle(Server.java:564)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:320)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:279)
at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:110)
at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:124)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:672)
at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:590)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.jasper.JasperException: The absolute uri: http://java.sun.com/jsp/jstl/fmt cannot be resolved in either web.xml or the jar files deployed with this application
at org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:55)
```
---
[GitHub] nifi pull request #1913: NIFI-3603���Localization needed
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1913#discussion_r121613477
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/bulletin-board/nf-bulletin-board.js ---
@@ -1,494 +1,494 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-/* global define, module, require, exports */
-
-(function (root, factory) {
- if (typeof define === 'function' && define.amd) {
- define(['jquery',
- 'angular',
- 'nf.Common',
- 'nf.ng.AppConfig',
- 'nf.ng.AppCtrl',
- 'nf.ng.ServiceProvider',
- 'nf.ng.Bridge',
- 'nf.ErrorHandler',
- 'nf.Storage'],
- function ($,
- angular,
- nfCommon,
- appConfig,
- appCtrl,
- serviceProvider,
- nfNgBridge,
- nfErrorHandler,
- nfStorage) {
- return (nf.ng.BulletinBoardCtrl =
- factory($,
+ /*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
--- End diff --
Is it possible to NOT make these unnecessary changes to make reviewing easier?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---