You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/08 03:27:10 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2660: fs: Reimplement file_open to not depend on nx_open

xiaoxiang781216 opened a new pull request #2660:
URL: https://github.com/apache/incubator-nuttx/pull/2660


   ## Summary
   And emove file_detach to enforce the kernel user call file_open directly instead
   
   ## Impact
   file_open can be called even before the idle task get initialized
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2660: fs: Reimplement file_open to not depend on nx_open

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2660:
URL: https://github.com/apache/incubator-nuttx/pull/2660#issuecomment-757230826


   Yes, I removed the temp variable to simplify the code and savde the stack space, other change is same as before.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2660: fs: Reimplement file_open to not depend on nx_open

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2660:
URL: https://github.com/apache/incubator-nuttx/pull/2660#issuecomment-757230826


   Yes, I removed the temp variable to simplify the code and savde the stack space, other change is same as before.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 merged pull request #2660: fs: Reimplement file_open to not depend on nx_open

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #2660:
URL: https://github.com/apache/incubator-nuttx/pull/2660


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2660: fs: Reimplement file_open to not depend on nx_open

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2660:
URL: https://github.com/apache/incubator-nuttx/pull/2660#issuecomment-757175119


   @xiaoxiang781216 did something change or you just rebased?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2660: fs: Reimplement file_open to not depend on nx_open

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2660:
URL: https://github.com/apache/incubator-nuttx/pull/2660#issuecomment-757175119


   @xiaoxiang781216 did something change or you just rebased?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org