You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2018/03/26 18:23:22 UTC
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9770
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
IMPALA-5721:
- Save profiles of queries at the end of both the spilling and
non-spilling binary search. These were not being saved before. Note
these profiles won't have ExecSummary until IMPALA-6640 is addressed.
- Save the profile of any query that produces incorrect results during
binary search. These were not being saved before, either.
- Use descriptive names, like
tpch_100_parquet_q12_profile_without_spilling.txt, for profiles
mentioned above. We do this by introducing the concept of a
"logical_query_id" whose values look like "tpch_100_parquet_q12".
- Use the logical_query_id in critical error paths and include the
logical_query_id in result hash files.
IMPALA-6717:
- Plumb --common-query-options through to the binary search.
IMPALA-6738:
- Begin a refactoring to reduce the number of parameters used when doing
the binary search.
- Introduce a notion of "curated args" via class that dispatches
curating args from parse_args() into internal form.
- Adjust populate_all_queries() to use curated_args
Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
---
M tests/stress/concurrent_select.py
1 file changed, 214 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/9770/6
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Nithya Janarthanan, David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9770
to look at the new patch set (#8).
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
IMPALA-5721:
- Save profiles of queries at the end of both the spilling and
non-spilling binary search. These were not being saved before. Note
these profiles won't have ExecSummary until IMPALA-6640 is addressed.
- Save the profile of any query that produces incorrect results during
binary search. These were not being saved before, either.
- Use descriptive names, like
tpch_100_parquet_q12_profile_without_spilling.txt, for profiles
mentioned above. We do this by introducing the concept of a
"logical_query_id" whose values look like "tpch_100_parquet_q12".
- Use the logical_query_id in critical error paths and include the
logical_query_id in result hash files.
IMPALA-6717:
- Plumb --common-query-options through to the binary search.
IMPALA-6738:
- Begin a refactoring to reduce the number of parameters used when doing
the binary search.
- Introduce a notion of "curated args" via class that dispatches
curating args from parse_args() into internal form.
- Adjust populate_all_queries() to use curated_args
Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
---
M tests/stress/concurrent_select.py
1 file changed, 219 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/9770/8
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Hello Nithya Janarthanan, David Knupp, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9770
to look at the new patch set (#9).
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
IMPALA-5721:
- Save profiles of queries at the end of both the spilling and
non-spilling binary search. These were not being saved before. Note
these profiles won't have ExecSummary until IMPALA-6640 is addressed.
- Save the profile of any query that produces incorrect results during
binary search. These were not being saved before, either.
- Use descriptive names, like
tpch_100_parquet_q12_profile_without_spilling.txt, for profiles
mentioned above. We do this by introducing the concept of a
"logical_query_id" whose values look like "tpch_100_parquet_q12".
- Use the logical_query_id in critical error paths and include the
logical_query_id in result hash files.
IMPALA-6717:
- Plumb --common-query-options through to the binary search.
IMPALA-6738:
- Begin a refactoring to reduce the number of parameters used when doing
the binary search.
- Introduce a notion of "converted args" via class that does the
conversion (if needed) via property getters.
- Adjust populate_all_queries() to use converted_args
Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
---
M tests/stress/concurrent_select.py
1 file changed, 213 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/9770/9
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 7:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/9770/1/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9770/1/tests/stress/concurrent_select.py@174
PS1, Line 174: LOG.warn(
> docstring
Done
http://gerrit.cloudera.org:8080/#/c/9770/1/tests/stress/concurrent_select.py@176
PS1, Line 176: "The stress test algorithm needs control of this option.".format(
: query_option=query_option, opt=args_common_quer
> Ideally we should also prefix query.logical_id. QueryReport doesn't own tha
Done
http://gerrit.cloudera.org:8080/#/c/9770/1/tests/stress/concurrent_select.py@708
PS1, Line 708: ry")
> Stale var of some older designs. Doesn't seem needed.
Nevermind, actually used now.
http://gerrit.cloudera.org:8080/#/c/9770/1/tests/stress/concurrent_select.py@1475
PS1, Line 1475: if old_required_mem_mb_with_spilling:
: mem_limit = old_required_mem_mb_with_spilling
: old_required_mem_mb_with_spilling = None
: else:
> Getting a little untenable. Maybe instead just save what we want instead of
Eh, withdrawn. The save list is still longer.
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@113
PS7, Line 113: class StressArgCurator(object):
> Nit: Is "curate" really the right word here? I think of the act of curating
Done
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@141
PS7, Line 141: if hasattr(self, curate_method_name):
> So, for what it's worth, rather that having these magic _curate_ methods, t
Nice idea. I tend to think __getattr__ is just as magical, and I tend to avoid using it, but I think the more magical one is __getattribute__. But you raise a good point and using __getattr__ means I don't need to do the dispatch. Since you said you'll be reviewing in batches, I'm going to think on this one a while before addressing it one way or another.
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@145
PS7, Line 145: curated_args[k] = v
> Nit: Might want to explicitly mention in either the class or function docst
Done. I tried to convey this L116-122, but it wasn't enough. I've tried again. Please let me know if it can be made clearer.
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 21:28:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 7:
(3 comments)
I'm probably going to do this in passes. This initial small set of comments is only for the StressArgCurator class.
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@113
PS7, Line 113: class StressArgCurator(object):
Nit: Is "curate" really the right word here? I think of the act of curating as filtering -- deciding what stays and what goes. This class does conversion or formatting more than curation.
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@141
PS7, Line 141: if hasattr(self, curate_method_name):
So, for what it's worth, rather that having these magic _curate_ methods, the way I would have done this would have been to design a class that simply "wrapped" the args you got from parse_args(). Something like:
class StressArgs(object):
def __init__(self, raw_args):
self.raw_args = raw_args
@property
def common_query_options(self):
# do stuff to return formatted common_query_options
@property
def runtime_info_path(self):
# do stuff to return formatted runtime_info_path
def __getattr__(self, attr):
"""This should return other attrs not explicitly re-cast as properties."""
return getattr(self.raw_args, attr)
Then you can just use it like:
stress_args = StressArgs(parser.parse_args())
stress_args.common_query_options # Defers to common_query_options property
stress_args.runtime_info_path # Defers to runtime_info_path property
stress_args.results_dir # Returns stress_args.raw_args.results_dir
etc...
I'll leave it up to you if you'd care to change this.
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@145
PS7, Line 145: curated_args[k] = v
Nit: Might want to explicitly mention in either the class or function docstring that only a portion of the args require conversion. Some are kept as is. That wasn't immediately clear to me.
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 20:58:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 6:
I didn't review the code in detail but the high-level goals of the patch make sense to me.
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Mar 2018 18:41:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@141
PS7, Line 141: argparse.Namespace
> Nice idea. I tend to think __getattr__ is just as magical, and I tend to av
Yeah, __getattribute__ is the weird one. I think of implementing __getattr__ as being on par with implementing __iter__ or __str__.
For what it's worth, if you do this, I'd just keep using "args", rather switching to some new variable name, i.e.:
args = StressArgs(parser.parse_args())
It might cut down on some unnecessary noise later in the diff.
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Mar 2018 22:01:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2203/
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 23:41:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Mar 2018 03:38:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
IMPALA-5721:
- Save profiles of queries at the end of both the spilling and
non-spilling binary search. These were not being saved before. Note
these profiles won't have ExecSummary until IMPALA-6640 is addressed.
- Save the profile of any query that produces incorrect results during
binary search. These were not being saved before, either.
- Use descriptive names, like
tpch_100_parquet_q12_profile_without_spilling.txt, for profiles
mentioned above. We do this by introducing the concept of a
"logical_query_id" whose values look like "tpch_100_parquet_q12".
- Use the logical_query_id in critical error paths and include the
logical_query_id in result hash files.
IMPALA-6717:
- Plumb --common-query-options through to the binary search.
IMPALA-6738:
- Begin a refactoring to reduce the number of parameters used when doing
the binary search.
- Introduce a notion of "converted args" via class that does the
conversion (if needed) via property getters.
- Adjust populate_all_queries() to use converted_args
Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Reviewed-on: http://gerrit.cloudera.org:8080/9770
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M tests/stress/concurrent_select.py
1 file changed, 213 insertions(+), 76 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 9: Code-Review+2
> Patch Set 7:
>
> (1 comment)
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 23:02:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 )
Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py
File tests/stress/concurrent_select.py:
http://gerrit.cloudera.org:8080/#/c/9770/7/tests/stress/concurrent_select.py@141
PS7, Line 141: if hasattr(self, curate_method_name):
> Yeah, __getattribute__ is the weird one. I think of implementing __getattr_
Somehow I missed this comment. I implemented your __getattr__, but not the args overwrite. So half-done in the latest patch set.
--
To view, visit http://gerrit.cloudera.org:8080/9770
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I33d036ec93df3016cd4703205078dbdba0168acb
Gerrit-Change-Number: 9770
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <nj...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Mar 2018 18:34:23 +0000
Gerrit-HasComments: Yes