You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/01 11:35:17 UTC
[GitHub] [kylin] RupengWang opened a new pull request #1129: KYLIN-4132
Kylin needn't use "org.apache.directory.api.util.Strings"
RupengWang opened a new pull request #1129: KYLIN-4132 Kylin needn't use "org.apache.directory.api.util.Strings"
URL: https://github.com/apache/kylin/pull/1129
Kylin needn't use "org.apache.directory.api.util.Strings" to import extra dependency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #1129: KYLIN-4132 Kylin
needn't use "org.apache.directory.api.util.Strings"
Posted by GitBox <gi...@apache.org>.
shaofengshi merged pull request #1129: KYLIN-4132 Kylin needn't use "org.apache.directory.api.util.Strings"
URL: https://github.com/apache/kylin/pull/1129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #1129: KYLIN-4132 Kylin
needn't use "org.apache.directory.api.util.Strings"
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on issue #1129: KYLIN-4132 Kylin needn't use "org.apache.directory.api.util.Strings"
URL: https://github.com/apache/kylin/pull/1129#issuecomment-593181443
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1129: KYLIN-4132 Kylin
needn't use "org.apache.directory.api.util.Strings"
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1129: KYLIN-4132 Kylin needn't use "org.apache.directory.api.util.Strings"
URL: https://github.com/apache/kylin/pull/1129#issuecomment-593089204
## Pull Request Test Coverage Report for [Build 5675](https://coveralls.io/builds/29054856)
* **0** of **5** **(0.0%)** changed or added relevant lines in **2** files are covered.
* **3** unchanged lines in **2** files lost coverage.
* Overall coverage remained the same at **27.527%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java](https://coveralls.io/builds/29054856/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FProjectService.java#L189) | 0 | 1 | 0.0%
| [server-base/src/main/java/org/apache/kylin/rest/service/JobService.java](https://coveralls.io/builds/29054856/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FJobService.java#L904) | 0 | 4 | 0.0%
<!-- | **Total:** | **0** | **5** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/29054856/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/29054856/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29054856) |
| :-- | --: |
| Change from base [Build 5670](https://coveralls.io/builds/29043776): | 0.0% |
| Covered Lines: | 24298 |
| Relevant Lines: | 88270 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] RupengWang commented on issue #1129: KYLIN-4132 Kylin
needn't use "org.apache.directory.api.util.Strings"
Posted by GitBox <gi...@apache.org>.
RupengWang commented on issue #1129: KYLIN-4132 Kylin needn't use "org.apache.directory.api.util.Strings"
URL: https://github.com/apache/kylin/pull/1129#issuecomment-593086975
CI passed. LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services