You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/27 09:24:20 UTC
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #9811: [Feature] [Vectorized] Some pre-refactorings or interface additions for schema change
BiteTheDDDDt opened a new pull request, #9811:
URL: https://github.com/apache/incubator-doris/pull/9811
# Proposed changes
This pr is part of #9375, included some refactorings or interface additions.
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9811: [Feature] [Vectorized] Some pre-refactorings or interface additions for schema change
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9811:
URL: https://github.com/apache/incubator-doris/pull/9811#discussion_r890829367
##########
be/src/olap/tablet_schema.h:
##########
@@ -23,6 +23,8 @@
#include "gen_cpp/segment_v2.pb.h"
#include "olap/olap_define.h"
#include "olap/types.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/data_types/data_type.h"
Review Comment:
why not delete the header and use pre define ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9811: [Feature] [Vectorized] Some pre-refactorings or interface additions for schema change
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9811:
URL: https://github.com/apache/incubator-doris/pull/9811#discussion_r889856054
##########
be/src/olap/tablet_schema.h:
##########
@@ -61,9 +63,18 @@ class TabletColumn {
size_t index_length() const { return _index_length; }
void set_index_length(size_t index_length) { _index_length = index_length; }
FieldAggregationMethod aggregation() const { return _aggregation; }
+ vectorized::AggregateFunctionPtr get_aggregate_function(vectorized::DataTypes argument_types,
Review Comment:
better define in `.cpp` and move header of "vec" to `.cpp`
##########
be/src/vec/common/cow.h:
##########
@@ -197,10 +195,10 @@ class COW {
return ret;
}
- void swap(intrusive_ptr& rhs) {
+ void swap(const intrusive_ptr& rhs) {
Review Comment:
why change to `const&` and use `const_cast` in function, look danger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9811: [Feature] [Vectorized] Some pre-refactorings or interface additions for schema change
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9811:
URL: https://github.com/apache/incubator-doris/pull/9811#issuecomment-1148269253
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt merged pull request #9811: [Feature] [Vectorized] Some pre-refactorings or interface additions for schema change
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #9811:
URL: https://github.com/apache/incubator-doris/pull/9811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9811: [Feature] [Vectorized] Some pre-refactorings or interface additions for schema change
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9811:
URL: https://github.com/apache/incubator-doris/pull/9811#issuecomment-1148269226
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org