You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/29 10:34:48 UTC

[GitHub] [arrow-datafusion] Dandandan commented on pull request #4010: MINOR: Generate expected benchmark query results

Dandandan commented on PR #4010:
URL: https://github.com/apache/arrow-datafusion/pull/4010#issuecomment-1295797942

   Looks great. I tried running the tests now against SF=1. I also had SF=10 running, but that one fails with more (my feeling is mostly rounding / overflow errors) and quite slow to read the files in CSV format.
   
   This is what I get with `TPCH_DATA=./tpch-dbgen/ cargo test --release -- --test-threads=1`
   ```
   running 66 tests
   test tests::q1 ... ok
   test tests::q10 ... ok
   test tests::q10_expected_plan ... ok
   test tests::q11 ... FAILED
   test tests::q11_expected_plan ... ok
   test tests::q12 ... ok
   test tests::q12_expected_plan ... ok
   test tests::q13 ... ok
   test tests::q13_expected_plan ... ok
   test tests::q14 ... FAILED
   test tests::q14_expected_plan ... ok
   test tests::q15 ... ok
   test tests::q15_expected_plan ... ok
   test tests::q16 ... ok
   test tests::q16_expected_plan ... ok
   test tests::q17 ... FAILED
   test tests::q17_expected_plan ... ignored
   test tests::q18 ... ok
   test tests::q18_expected_plan ... ok
   test tests::q19 ... ok
   test tests::q19_expected_plan ... ok
   test tests::q1_expected_plan ... ok
   test tests::q2 ... ok
   test tests::q20 ... ok
   test tests::q20_expected_plan ... ok
   test tests::q21 ... ok
   test tests::q21_expected_plan ... ok
   test tests::q22 ... ok
   test tests::q22_expected_plan ... ok
   test tests::q2_expected_plan ... ok
   test tests::q3 ... ok
   test tests::q3_expected_plan ... ok
   test tests::q4 ... ok
   test tests::q4_expected_plan ... ok
   test tests::q5 ... ok
   test tests::q5_expected_plan ... ok
   test tests::q6 ... FAILED
   test tests::q6_expected_plan ... ok
   test tests::q7 ... ok
   test tests::q7_expected_plan ... ok
   test tests::q8 ... ok
   test tests::q8_expected_plan ... ok
   test tests::q9 ... FAILED
   test tests::q9_expected_plan ... ok
   test tests::run_q1 ... ok
   test tests::run_q10 ... ok
   test tests::run_q11 ... ok
   test tests::run_q12 ... ok
   test tests::run_q13 ... ok
   test tests::run_q14 ... ok
   test tests::run_q15 ... ok
   test tests::run_q16 ... ok
   test tests::run_q17 ... ok
   test tests::run_q18 ... ok
   test tests::run_q19 ... ok
   test tests::run_q2 ... ok
   test tests::run_q20 ... ok
   test tests::run_q21 ... ok
   test tests::run_q22 ... ok
   test tests::run_q3 ... ok
   test tests::run_q4 ... ok
   test tests::run_q5 ... ok
   test tests::run_q6 ... ok
   test tests::run_q7 ... ok
   test tests::run_q8 ... ok
   test tests::run_q9 ... ok
   
   failures:
   
   ---- tests::q11 stdout ----
   Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 11, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
   Query 11 iteration 0 took 824.6 ms and returned 29571 rows
   Query 11 avg time: 824.63 ms
   thread 'main' panicked at 'assertion failed: `(left == right)`
     left: `1048`,
    right: `29571`', benchmarks/src/bin/tpch.rs:1411:13
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   
   ---- tests::q14 stdout ----
   Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 14, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
   Query 14 iteration 0 took 2749.8 ms and returned 1 rows
   Query 14 avg time: 2749.84 ms
   thread 'main' panicked at 'assertion failed: schema_matches', benchmarks/src/bin/tpch.rs:1404:13
   
   ---- tests::q17 stdout ----
   Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 17, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
   Query 17 iteration 0 took 9599.6 ms and returned 1 rows
   Query 17 avg time: 9599.62 ms
   thread 'main' panicked at 'assertion failed: schema_matches', benchmarks/src/bin/tpch.rs:1404:13
   
   ---- tests::q6 stdout ----
   Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 6, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
   Query 6 iteration 0 took 2957.9 ms and returned 1 rows
   Query 6 avg time: 2957.93 ms
   thread 'main' panicked at 'assertion failed: `(left == right)`
     left: `["123141078.23"]`,
    right: `["75207429.08"]`', benchmarks/src/bin/tpch.rs:1415:17
   
   ---- tests::q9 stdout ----
   Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 9, debug: false, iterations: 1, partitions: 2, batch_size: 8192, path: "./tpch-dbgen/", file_format: "tbl", mem_table: false, output_path: None, disable_statistics: false }
   Query 9 iteration 0 took 3962.8 ms and returned 175 rows
   Query 9 avg time: 3962.77 ms
   thread 'main' panicked at 'assertion failed: `(left == right)`
     left: `["MOROCCO", "1997", "42698382.85"]`,
    right: `["MOROCCO", "1997", "42698382.86"]`', benchmarks/src/bin/tpch.rs:1415:17
   
   
   failures:
       tests::q11
       tests::q14
       tests::q17
       tests::q6
       tests::q9
   ```
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org