You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/21 14:51:41 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #15256: [fix][jdk17] Enable Netty and BookKeeper IO optimizations on jdk17
nicoloboschi opened a new pull request, #15256:
URL: https://github.com/apache/pulsar/pull/15256
### Motivation
Follow up of https://github.com/apache/pulsar/pull/14999.
Based on https://github.com/netty/netty/issues/12265 and https://github.com/apache/bookkeeper/pull/3234 it is better to open other modules.
### Modifications
* Open `java.base/java.util.zip` module for BookKeeper
* Open `java.base/jdk.internal.misc` module for Netty
Note that the functions worker will spawn the process without these optimizations. It could be useful in case the connector uses Netty. Very unlikely that the function uses BookKeeper. I can follow up the Netty ones in another pull (with a lower priority).
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15256: [fix][jdk17] Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15256:
URL: https://github.com/apache/pulsar/pull/15256#issuecomment-1106591500
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #15256: [fix][jdk17] Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #15256:
URL: https://github.com/apache/pulsar/pull/15256#issuecomment-1105842126
> Very unlikely that the function uses BookKeeper.
@nicoloboschi - a function instance connects to bookkeeper when running stateful functions. I don't know any helpful client internals to determine if we'd need to look closer, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15256: [fix][jdk17] Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15256:
URL: https://github.com/apache/pulsar/pull/15256#issuecomment-1106436504
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #15256: [fix][jdk17] Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
lhotari merged PR #15256:
URL: https://github.com/apache/pulsar/pull/15256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15256: [fix][jdk17] Enable Netty and BookKeeper IO optimizations on jdk17
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15256:
URL: https://github.com/apache/pulsar/pull/15256#issuecomment-1106621742
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org