You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/09/25 09:19:09 UTC
[GitHub] codecov-io edited a comment on issue #2554: code format
codecov-io edited a comment on issue #2554: code format
URL: https://github.com/apache/incubator-dubbo/pull/2554#issuecomment-424267858
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2554?src=pr&el=h1) Report
> Merging [#2554](https://codecov.io/gh/apache/incubator-dubbo/pull/2554?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/0d20194cadada4f131395e9d0fff0a89ca2fe3bc?src=pr&el=desc) will **decrease** coverage by `0.52%`.
> The diff coverage is `58.65%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2554?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2554 +/- ##
============================================
- Coverage 55.01% 54.49% -0.53%
- Complexity 5280 5506 +226
============================================
Files 573 595 +22
Lines 25517 27496 +1979
Branches 4531 4819 +288
============================================
+ Hits 14039 14984 +945
- Misses 9377 10302 +925
- Partials 2101 2210 +109
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2554?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dubbo/common/bytecode/ClassGenerator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvQ2xhc3NHZW5lcmF0b3IuamF2YQ==) | `59.34% <58.65%> (+0.33%)` | `46 <46> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `7% <0%> (-1%)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `56.47% <0%> (-5.89%)` | `21% <0%> (-2%)` | |
| [...e/dubbo/remoting/transport/netty4/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVyLmphdmE=) | `72.13% <0%> (-3.28%)` | `9% <0%> (-1%)` | |
| [...bbo/rpc/protocol/thrift/io/InputStreamWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvaW8vSW5wdXRTdHJlYW1XcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...o/rpc/protocol/thrift/DubboClassNameGenerator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvRHViYm9DbGFzc05hbWVHZW5lcmF0b3IuamF2YQ==) | `100% <0%> (ø)` | `3% <0%> (?)` | |
| [.../java/org/apache/dubbo/common/json/JSONWriter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9KU09OV3JpdGVyLmphdmE=) | `63.15% <0%> (ø)` | `19% <0%> (?)` | |
| [...a/org/apache/dubbo/common/json/ParseException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9QYXJzZUV4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | `0% <0%> (?)` | |
| [...n/java/org/apache/dubbo/common/json/JSONArray.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9KU09OQXJyYXkuamF2YQ==) | `14.28% <0%> (ø)` | `3% <0%> (?)` | |
| [.../main/java/org/apache/dubbo/common/json/Yylex.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9ZeWxleC5qYXZh) | `65.56% <0%> (ø)` | `46% <0%> (?)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2554/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2554?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2554?src=pr&el=footer). Last update [0d20194...ddf6902](https://codecov.io/gh/apache/incubator-dubbo/pull/2554?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org