You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/26 08:47:14 UTC
[GitHub] [maven-surefire] andpab opened a new pull request #352: Surefire 1914
andpab opened a new pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352
This is work in progress. It does the job, but may not be the best or most appropriate way to do it.
I'm not particularly happy with the !display.startsWith( "[" ) in the needsSpaceSeparator condition in particular.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #352: [SUREFIRE-1914] Take displayName of container into account for XML reporting of @ParameterizedTest
Posted by GitBox <gi...@apache.org>.
Tibor17 merged pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #352: [SUREFIRE-1914] Draft: Take displayName of container into account for XML reporting of @ParameterizedTest
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352#issuecomment-858501015
@andpab
I have approved this PR in order to force the CI build. Let's see if the tests would pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #352: [SUREFIRE-1914] Draft: Take displayName of container into account for XML reporting of @ParameterizedTest
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352#issuecomment-877696755
@andpab
Sorry, I was busy with other issues.
LGTM
Feel free to squash both commits and we will go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #352: [SUREFIRE-1914] Take displayName of container into account for XML reporting of @ParameterizedTest
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352#issuecomment-879424513
@andpab
Thx for contributing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #352: [SUREFIRE-1914] Take displayName of container into account for XML reporting of @ParameterizedTest
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352#issuecomment-879378082
@andpab
yes I see, now the CI is running. Let's wait 2 hours for the outcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #352: [SUREFIRE-1914] Draft: Take displayName of container into account for XML reporting of @ParameterizedTest
Posted by GitBox <gi...@apache.org>.
andpab commented on pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352#issuecomment-861331943
CI build seems to have been successful.
@Tibor17 What are the next steps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #352: [SUREFIRE-1914] Take displayName of container into account for XML reporting of @ParameterizedTest
Posted by GitBox <gi...@apache.org>.
andpab commented on pull request #352:
URL: https://github.com/apache/maven-surefire/pull/352#issuecomment-879374942
Rebased to upstream master and squashed the two commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org