[GitHub] [hbase] virajjasani commented on a change in pull request #3218: HBASE-25835 Ignore duplicate split requests from regionserver reports

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #3218:
URL: https://github.com/apache/hbase/pull/3218#discussion_r625094670



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -1126,7 +1126,13 @@ private void updateRegionSplitTransition(final ServerName serverName, final Tran
       LOG.debug("Split request from " + serverName +
           ", parent=" + parent + " splitKey=" + Bytes.toStringBinary(splitKey));
     }
-    master.getMasterProcedureExecutor().submitProcedure(createSplitProcedure(parent, splitKey));
+    if (regionStates.getRegionState(parent).isOpened() &&

Review comment:
       > And do we need to check whether it is null?
   
   Just to understand better, while creating Split Procedure, `regionStates.getRegionState(parent)` returning `null` should not happen right because we are trying to split an existing region (must be present in AM)? Or did I miss some race condition?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org