You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/07 20:30:46 UTC
[GitHub] [incubator-devlake] keon94 opened a new pull request, #3012: [issue-2908]: Bump lake-builder version to 0.0.8
keon94 opened a new pull request, #3012:
URL: https://github.com/apache/incubator-devlake/pull/3012
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
# Summary
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Does this close any open issues?
Closes #2908
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #3012: [issue-2908]: Bump lake-builder version to 0.0.8
Posted by GitBox <gi...@apache.org>.
keon94 commented on code in PR #3012:
URL: https://github.com/apache/incubator-devlake/pull/3012#discussion_r965369774
##########
.github/workflows/golangci-lint.yml:
##########
@@ -41,5 +41,5 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
- version: v1.43.0
Review Comment:
1.43 won't work with Go 1.18+, so had to upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on pull request #3012: [issue-2908]: Bump lake-builder version to 0.0.8
Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #3012:
URL: https://github.com/apache/incubator-devlake/pull/3012#issuecomment-1240216270
@klesh this is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] mindlesscloud merged pull request #3012: [issue-2908]: Bump lake-builder version to 0.0.8
Posted by GitBox <gi...@apache.org>.
mindlesscloud merged PR #3012:
URL: https://github.com/apache/incubator-devlake/pull/3012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #3012: [issue-2908]: Bump lake-builder version to 0.0.8
Posted by GitBox <gi...@apache.org>.
keon94 commented on code in PR #3012:
URL: https://github.com/apache/incubator-devlake/pull/3012#discussion_r965369998
##########
devops/lake-builder/Dockerfile:
##########
@@ -14,20 +14,24 @@
# limitations under the License.
#
-# current tag: mericodev/lake-builder:0.0.5
+# current tag: mericodev/lake-builder:0.0.8
FROM alpine:3.15 as builder
# this distro version gives us libgit2 1.3.0 which we want for gitextractor
RUN apk update && apk upgrade && apk add libgit2-dev
-FROM golang:1.19.0-alpine3.16
+FROM golang:1.19.1-alpine3.16
# libs/headers needed to compile gitextractor
+# copy headers over directly (it'll be a new dir)
COPY --from=builder /usr/include /usr/include
-COPY --from=builder /usr/lib/libgit2.so /usr/lib/libgit2.so
-COPY --from=builder /usr/lib/libgit2.so.1.3 /usr/lib/libgit2.so.1.3
-COPY --from=builder /usr/lib/libpkgconf.so.3 /usr/lib/libpkgconf.so.3
+# copy all contents of the base lib to a temp directory to avoid overwrites of newer versions
Review Comment:
safer, more robust solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on pull request #3012: [issue-2908]: Bump lake-builder version to 0.0.8
Posted by GitBox <gi...@apache.org>.
keon94 commented on PR #3012:
URL: https://github.com/apache/incubator-devlake/pull/3012#issuecomment-1240012942
The linter errors must be due to the Linter version upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org