[PATCH] md4 WAS: RE: buckets, brigades, md5

[Sander Striker <st...@samba-tng.org>]

Hi,

[...]
Sander> Regarding MD4, I only have a link to RFC1320 for you:
Sander> http://www.faqs.org/rfcs/rfc1320.html
Sander>
Sander> Which contains reference code...

Greg> You want it, then you can do the work :-)  (i.e. post a patch)

Ok, here it is. It adds the following to apr:
include/apr_md4.h
passwd/apr_md4.c

This is probably not the correct location. It actually should go in
apr-util in the crypto department, but anyway.
Oh, come to think of it, since there is no apr_md4_encode function,
the #includes can probably be cleaned up in apr_md4.c.

I also updated the md5 code (removed all tab characters and the reference
to UINT4, which really should be an apr_uint32_t instead of a typedef'd
unsigned int).

Greg> Although... I would ask, "who needs this?" I don't think that MD4 is
Greg> generally useful, so I would question its inclusion into APRUTIL. MD5
and
Greg> SHA1... those are modern/current and get used. But MD4? I had
completely
Greg> forgotten about that one until you mentioned it.

Well some old code uses md4. And sometimes you just need to stay backwards
compatible.

Sander

Re: [PATCH] md4 WAS: RE: buckets, brigades, md5

[Justin Erenkrantz <je...@ebuilt.com>]

On Mon, May 28, 2001 at 11:00:40AM +0200, Sander Striker wrote:
> Hi,
> 
> [...]
> Sander> Regarding MD4, I only have a link to RFC1320 for you:
> Sander> http://www.faqs.org/rfcs/rfc1320.html
> Sander>
> Sander> Which contains reference code...
> 
> Greg> You want it, then you can do the work :-)  (i.e. post a patch)
> 
> Ok, here it is. It adds the following to apr:
> include/apr_md4.h
> passwd/apr_md4.c

IIRC, some of the Win32 password algorithms rely on MD4 - if so, I 
think this is why you guys want to see it.  It's been years since I
touched Win32, but a bell went off when you brought up MD4.

If no one beats me to it, I'll add this to apr-util/crypto.  No reason 
it should be in apr just because md5 is.  I'm planning to move md5 out 
to apr-util - just as soon as I figure out what to do with uuid.

FWIW, I have a first pass at the date stuff ready for apr-util.

As I'm still waiting for my apache.org account to be created (I think it
might have gotten delayed to due to other issues - I can wait until they
are addressed), I can't commit just yet.  So, this may take a few days 
for me to add.  If someone else wants to go ahead before then, feel free.
Nothing much I can do right now.  =)

Once I'm ready to commit this, I'll look at the code to make sure I 
don't have any gotchas or comments on it - someone else may review 
it before then.  I won't look at it until I'm ready to commit.  If 
I have any concerns, I'll post them then.  -- justin