[jira] [Commented] (MAPREDUCE-4637) Killing an unassigned task attempt causes the job to fail

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479682#comment-13479682 ] 

Siddharth Seth commented on MAPREDUCE-4637:
-------------------------------------------

bq. I don't see a reason to change that since users may have a reason to kill a task attempt before it is running. The bug here is that the unassigned state of the task attempt does not have a TA_DIAGNOSTICS_UPDATE transition which causes the kill to fail.
A kill seems to be a valid operation before an attempt starts. At a later point, maybe we should include diagnostic messages along with the actual event instead of 2 independent events.

The patch needs some minor changes though. There's an extra Diagnostic Event being generated from TaskImpl - which isn't required. The unit tests may be mocking more than they should, but I don't see that as being an issue.
                
> Killing an unassigned task attempt causes the job to fail
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-4637
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4637
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.0.0-alpha
>            Reporter: Tom White
>            Assignee: Mayank Bansal
>         Attachments: MAPREDUCE-4637-trunk.patch, MAPREDUCE-4637-trunk-v2.patch, MAPREDUCE-4637-trunk-v3.patch, MAPREDUCE-4637-trunk-v4.patch, MapReduce.png
>
>
> Attempting to kill a task attempt that has been scheduled but is not running causes an invalid state transition and the AM to stop with an error. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira