You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/07/31 17:04:14 UTC
[jira] Created: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
[classlib][beans] fails in CustomizedPersistenceDelegateTest
------------------------------------------------------------
Key: HARMONY-1015
URL: http://issues.apache.org/jira/browse/HARMONY-1015
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: winXP
Reporter: Alexei Zakharov
Attachments: CustomizedPDTest1.patch
Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
Attached patch enables following tests:
testArrayPD
testPrimitivePD
I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=all ]
Mikhail Loenko resolved HARMONY-1015.
-------------------------------------
Resolution: Fixed
applied in revision 429940
Alexei, please verify it is done as expected
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=all ]
Mikhail Loenko closed HARMONY-1015.
-----------------------------------
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=comments#action_12426428 ]
Mikhail Loenko commented on HARMONY-1015:
-----------------------------------------
Hi Alexei. What is the reason for commenting out rather than removing the code?
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=comments#action_12433399 ]
Alexei Zakharov commented on HARMONY-1015:
------------------------------------------
verified, thanks Mikhail
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=comments#action_12426528 ]
Alexei Zakharov commented on HARMONY-1015:
------------------------------------------
Hi Mikhail, actually there is no big reason here. I just too shy to suggest such an agressive (more than 50%) code cutoff. :-) In fact, the code of main1() method contains some drafts for testing of persistence delegates for collection types we may need in the future. But we need to implement such persistence delegates (for collection types) beforehand since we don't have them implemented right now. In brief, you may delete the commented code if you like.
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=all ]
Mikhail Loenko reassigned HARMONY-1015:
---------------------------------------
Assignee: Mikhail Loenko
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=all ]
Alexei Zakharov updated HARMONY-1015:
-------------------------------------
Attachment: CustomizedPDTest1.patch
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1015) [classlib][beans] fails in
CustomizedPersistenceDelegateTest
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1015?page=comments#action_12424558 ]
Alexei Zakharov commented on HARMONY-1015:
------------------------------------------
I have also added some assertions to PersistenceDelegate, ArrayPersistenceDelegate and NullPersistenceDelegate. This helps to improve the readability of the code a little bit.
> [classlib][beans] fails in CustomizedPersistenceDelegateTest
> ------------------------------------------------------------
>
> Key: HARMONY-1015
> URL: http://issues.apache.org/jira/browse/HARMONY-1015
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: CustomizedPDTest1.patch
>
>
> Five tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest fail currently due RI incompatibility of our implementation of beans. There are some statement processing issues - our implementation doesn't really execute statements while constructing of tentative objects. Just logs them. The spec doesn't say anything about this but RI behaves exactly as written in tests. Therefore, we should enable these tests on our implementation in order to be compatible with RI.
> Attached patch enables following tests:
> testArrayPD
> testPrimitivePD
> I have found a lot of redundant code in CustomizedPersistenceDelegateTest. I just commented it out.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira