You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "thstieler (via GitHub)" <gi...@apache.org> on 2025/01/21 14:33:14 UTC
[PR] Optionally force UTF-8 encoding for IPTC records [commons-imaging]
thstieler opened a new pull request, #477:
URL: https://github.com/apache/commons-imaging/pull/477
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
This pull request adds the option to enforce UTF-8 encoding for writing IPTC records to jpeg files.
This can improve the reliability for correct parsing of IPTC records written by commons-imaging, because some libraries/applications use UTF-8 as default charset when reading IPTC records.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally force UTF-8 encoding for IPTC records [commons-imaging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #477:
URL: https://github.com/apache/commons-imaging/pull/477#issuecomment-2605109672
@thstieler
Thank you for the update, merged! 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally force UTF-8 encoding for IPTC records [commons-imaging]
Posted by "thstieler (via GitHub)" <gi...@apache.org>.
thstieler commented on PR #477:
URL: https://github.com/apache/commons-imaging/pull/477#issuecomment-2605133743
@garydgregory Thank you very much, that's great :-)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally force UTF-8 encoding for IPTC records [commons-imaging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #477:
URL: https://github.com/apache/commons-imaging/pull/477#issuecomment-2605083446
@thstieler
It looks like you did not follow the PR template, specfically:
- [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally force UTF-8 encoding for IPTC records [commons-imaging]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #477:
URL: https://github.com/apache/commons-imaging/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optionally force UTF-8 encoding for IPTC records [commons-imaging]
Posted by "thstieler (via GitHub)" <gi...@apache.org>.
thstieler commented on PR #477:
URL: https://github.com/apache/commons-imaging/pull/477#issuecomment-2605100893
@garydgregory You're right, unfortunately I forgot to remove trailing whitespace in one line, now mvn completes successfully!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org