[GitHub] [beam] KevinGG commented on a change in pull request #17072: [BEAM-14091] Fixing Interactive Beam show/collect for remote runners

[GitBox <gi...@apache.org>]

KevinGG commented on a change in pull request #17072:
URL: https://github.com/apache/beam/pull/17072#discussion_r826358849



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -454,8 +455,12 @@ def record(self, pcolls, max_n, max_duration):
           'options is deprecated since First stable release. References to '
           '<pipeline>.options will not be supported',
           category=DeprecationWarning)
-      pf.PipelineFragment(list(uncomputed_pcolls),
-                          self.user_pipeline.options).run(blocking=True)
+      from apache_beam.runners.portability.flink_runner import FlinkRunner
+      flink_runner_used = isinstance(

Review comment:
       You may make this `is_remote_run` so that the blocking is more self-explained. Also, you can check if the cache root of the current pipeline's cache manager is on GCS instead of checking the runner type: so no matter what runner the run uses, as long as you need to wait for the file on GCS, you run it blocking.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org