[GitHub] [superset] rusackas commented on a change in pull request #14844: feat: add pagination to change dataset modal

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #14844:
URL: https://github.com/apache/superset/pull/14844#discussion_r640372995



##########
File path: superset-frontend/src/datasource/ChangeDatasourceModal.tsx
##########
@@ -208,6 +211,28 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
     return data;
   };
 
+  const customGotoPage = (p: number) => {
+    SupersetClient.get({
+      endpoint: `/api/v1/dataset/?q=${rison.encode({
+        order_column: 'changed_on_delta_humanized',
+        order_direction: 'desc',
+        page: p - 1,
+        page_size: 20,
+      })}`,
+    }).then(resources => {
+      setPageIndex(p - 1);
+      setResourceCollection(resources.json.result);
+    });
+  };
+
+  const styleOverride = css`
+    .table-condensed {

Review comment:
       Since it's the `TableView` component is using this `className`, you could add the `css` prop to `TableView` component directly, rather than this ancestor. Then you don't have to have the class selector in the styles here, and the styles are closer to where they're used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org