You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/06 00:24:41 UTC
[GitHub] [fineract] nnatarajan opened a new pull request #751: FINERACT-122
added clientId, officeId, and groupId.
nnatarajan opened a new pull request #751: FINERACT-122 added clientId, officeId, and groupId.
URL: https://github.com/apache/fineract/pull/751
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] nnatarajan commented on issue #751: FINERACT-122 added
clientId, officeId, and groupId.
Posted by GitBox <gi...@apache.org>.
nnatarajan commented on issue #751: FINERACT-122 added clientId, officeId, and groupId.
URL: https://github.com/apache/fineract/pull/751#issuecomment-610568081
Thank you, @awasum! That is very kind of you! Let me know if I need to make any changes to this one or to other PR - FINERACT-538.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #751: FINERACT-122 added
clientId, officeId, and groupId.
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #751: FINERACT-122 added clientId, officeId, and groupId.
URL: https://github.com/apache/fineract/pull/751#issuecomment-609730297
@vorburger ...one of Mifos Outreachy Applicant sending her first PR. CC @edcable
Thanks for your contributions @nnatarajan . This will be reviewed and merged or feedback provided withing the next 48 hours. We hope you stay with us and keep learning and making contributions on Apache Fineract and Mifos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #751: FINERACT-122 added
clientId, officeId, and groupId.
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #751: FINERACT-122 added clientId, officeId, and groupId.
URL: https://github.com/apache/fineract/pull/751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services