You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "andriiiiiko (via GitHub)" <gi...@apache.org> on 2026/04/23 12:30:09 UTC

[PR] fix(i18n): correct Ukrainian locale flag code and language name typo [superset]

andriiiiiko opened a new pull request, #39593:
URL: https://github.com/apache/superset/pull/39593

   - Fix flag code from "uk" (United Kingdom 🇬🇧) to "ua" (Ukraine 🇺🇦)
   - Fix typo in language name: "Ukranian" → "Ukrainian"
   
   ### SUMMARY
   The Ukrainian locale had two bugs:
   - Flag code was set to "uk" which maps to United Kingdom 🇬🇧 instead of "ua" for Ukraine 🇺🇦
   - Language name had a typo: "Ukranian" instead of "Ukrainian"
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Not applicable — config-only change, no visual diff available.
   
   ### TESTING INSTRUCTIONS
   1. Add "uk" to LANGUAGES in superset_config.py
   2. Switch language to Ukrainian in Settings → Language
   3. Verify the Ukrainian flag 🇺🇦 appears in the language selector instead of 🇬🇧
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(i18n): correct Ukrainian locale flag code and language name typo [superset]

Posted by "andriiiiiko (via GitHub)" <gi...@apache.org>.

andriiiiiko commented on PR #39593:
URL: https://github.com/apache/superset/pull/39593#issuecomment-4304630737

   Fixes #37875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(i18n): correct Ukrainian locale flag code and language name typo [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.

bito-code-review[bot] commented on PR #39593:
URL: https://github.com/apache/superset/pull/39593#issuecomment-4304356176

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(i18n): correct Ukrainian locale flag code and language name typo [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.

hainenber merged PR #39593:
URL: https://github.com/apache/superset/pull/39593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(i18n): correct Ukrainian locale flag code and language name typo [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.

codecov[bot] commented on PR #39593:
URL: https://github.com/apache/superset/pull/39593#issuecomment-4305137005

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39593?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 55.50%. Comparing base ([`d62f154`](https://app.codecov.io/gh/apache/superset/commit/d62f1546aa450bc74821a229edf0ad562d13d6a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ec9ffd7`](https://app.codecov.io/gh/apache/superset/commit/ec9ffd72a5936162185036bffed3309dcf1f086f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #39593      +/-   ##
   ==========================================
   - Coverage   64.58%   55.50%   -9.08%     
   ==========================================
     Files        2564     2564              
     Lines      133576   133576              
     Branches    31033    31033              
   ==========================================
   - Hits        86271    74146   -12125     
   - Misses      45813    58778   +12965     
   + Partials     1492      652     -840     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.66% <ø> (ø)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.66% <ø> (-20.45%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/39593/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39593?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(i18n): correct Ukrainian locale flag code and language name typo [superset]

Posted by "hainenber (via GitHub)" <gi...@apache.org>.

hainenber commented on PR #39593:
URL: https://github.com/apache/superset/pull/39593#issuecomment-4305294883

   Thank you for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org