You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2015/12/17 19:18:29 UTC
Review Request 41521: Force Windows to always use Unix line endings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41521/
-----------------------------------------------------------
Review request for Aurora and John Sirois.
Bugs: AURORA-1354
https://issues.apache.org/jira/browse/AURORA-1354
Repository: aurora
Description
-------
Since everything is run inside an Ubuntu VM, we want to ensure the line endings don't get auto-translated.
Diffs
-----
.gitattributes a5ab8cf17a14d2527e2a765ff94c3a74e719e0f4
Diff: https://reviews.apache.org/r/41521/diff/
Testing
-------
Applied settings to a checkout on a windows box and verified I was able to provision a VM w/ Vagrant and connect to the scheduler there.
Thanks,
Joshua Cohen
Re: Review Request 41521: Force Windows to always use Unix line
endings.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41521/#review111002
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Dec. 17, 2015, 11:18 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41521/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 11:18 a.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Bugs: AURORA-1354
> https://issues.apache.org/jira/browse/AURORA-1354
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Since everything is run inside an Ubuntu VM, we want to ensure the line endings don't get auto-translated.
>
>
> Diffs
> -----
>
> .gitattributes a5ab8cf17a14d2527e2a765ff94c3a74e719e0f4
>
> Diff: https://reviews.apache.org/r/41521/diff/
>
>
> Testing
> -------
>
> Applied settings to a checkout on a windows box and verified I was able to provision a VM w/ Vagrant and connect to the scheduler there.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 41521: Force Windows to always use Unix line
endings.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41521/#review111021
-----------------------------------------------------------
Ship it!
Master (c912c34) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 17, 2015, 6:18 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41521/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 6:18 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Bugs: AURORA-1354
> https://issues.apache.org/jira/browse/AURORA-1354
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Since everything is run inside an Ubuntu VM, we want to ensure the line endings don't get auto-translated.
>
>
> Diffs
> -----
>
> .gitattributes a5ab8cf17a14d2527e2a765ff94c3a74e719e0f4
>
> Diff: https://reviews.apache.org/r/41521/diff/
>
>
> Testing
> -------
>
> Applied settings to a checkout on a windows box and verified I was able to provision a VM w/ Vagrant and connect to the scheduler there.
>
>
> Thanks,
>
> Joshua Cohen
>
>