You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/07/13 05:55:38 UTC
[GitHub] [parquet-mr] ggershinsky opened a new pull request #800: PARQUET-1884: Encryption branch merge in master
ggershinsky opened a new pull request #800:
URL: https://github.com/apache/parquet-mr/pull/800
Merges encryption feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] ggershinsky commented on pull request #800: PARQUET-1884: Encryption branch merge in master
Posted by GitBox <gi...@apache.org>.
ggershinsky commented on pull request #800:
URL: https://github.com/apache/parquet-mr/pull/800#issuecomment-665100305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #800: PARQUET-1884: Encryption branch merge in master
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #800:
URL: https://github.com/apache/parquet-mr/pull/800#discussion_r461553080
##########
File path: parquet-hadoop/README.md
##########
@@ -239,6 +239,12 @@ conf.set("parquet.bloom.filter.expected.ndv#column.path", 200)
**Description:** Whether to write out page level checksums.
**Default value:** `true`
+---
+
+**Property:** `parquet.crypto.factory.class`
+**Description:** Class implementing EncryptionPropertiesFactory.
Review comment:
Please, add double spaces to the end of the lines to enforce newlines. (Maybe it was my mistake during the rebase that they were removed.)
(You may check the result by reviewing the rendering of the file on the github UI.)
##########
File path: .travis.yml
##########
@@ -1,4 +1,5 @@
language: java
+jdk: openjdk8
Review comment:
jdk is already listed, this one is not required
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #800: PARQUET-1884: Encryption branch merge in master
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #800:
URL: https://github.com/apache/parquet-mr/pull/800#issuecomment-664873157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org