You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2016/01/23 01:02:22 UTC

Review Request 42674: Replaced busybox with alpine in docker tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.


Repository: mesos


Description
-------

Replaced busybox with alpine in docker tests.
Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.


Diffs
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
  src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 

Diff: https://reviews.apache.org/r/42674/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Timothy Chen <tn...@apache.org>.

> On Jan. 23, 2016, 1 a.m., Guangya Liu wrote:
> > I saw that many test cases are using busybox, why only updating this one's image? Is it possible to update all busybox to alpine? As the alpine was built around musl libc and BusyBox. The image is only 5 MB in size and has access to a package repository that is much more complete than other BusyBox based images.

Hi Guangya, there aren't any tests that I know of still using busybox. If you search for busybox in the tests folder, they are just references and not actually pulling or using the busybox image itself. The intention of this is to replace all busybox images to alpine.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115959
-----------------------------------------------------------


On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Guangya Liu <gy...@gmail.com>.

> On 一月 23, 2016, 1 a.m., Guangya Liu wrote:
> > I saw that many test cases are using busybox, why only updating this one's image? Is it possible to update all busybox to alpine? As the alpine was built around musl libc and BusyBox. The image is only 5 MB in size and has access to a package repository that is much more complete than other BusyBox based images.
> 
> Timothy Chen wrote:
>     Hi Guangya, there aren't any tests that I know of still using busybox. If you search for busybox in the tests folder, they are just references and not actually pulling or using the busybox image itself. The intention of this is to replace all busybox images to alpine.

What about this one https://github.com/apache/mesos/blob/master/src/examples/docker_no_executor_framework.cpp#L106 ? This was not a unit test, but may also deserve a fix?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115959
-----------------------------------------------------------


On 一月 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated 一月 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115959
-----------------------------------------------------------



I saw that many test cases are using busybox, why only updating this one's image? Is it possible to update all busybox to alpine? As the alpine was built around musl libc and BusyBox. The image is only 5 MB in size and has access to a package repository that is much more complete than other BusyBox based images.

- Guangya Liu


On 一月 23, 2016, 12:02 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated 一月 23, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Timothy Chen <tn...@apache.org>.

> On Jan. 23, 2016, 12:14 a.m., Isabel Jimenez wrote:
> > src/tests/health_check_tests.cpp, line 351
> > <https://reviews.apache.org/r/42674/diff/1/?file=1218661#file1218661line351>
> >
> >     Why can't we be consistent and use the official alpine image here too?

Sorry that was a mistake.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115956
-----------------------------------------------------------


On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Isabel Jimenez <co...@isabeljimenez.com>.

> On Jan. 23, 2016, 12:14 a.m., Isabel Jimenez wrote:
> >

+1 for this change. Alpine is great.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115956
-----------------------------------------------------------


On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115956
-----------------------------------------------------------




src/tests/health_check_tests.cpp (line 351)
<https://reviews.apache.org/r/42674/#comment176994>

    Why can't we be consistent and use the official alpine image here too?


- Isabel Jimenez


On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Timothy Chen <tn...@apache.org>.

> On Jan. 25, 2016, 8:43 a.m., Bernd Mathiske wrote:
> > src/tests/health_check_tests.cpp, line 351
> > <https://reviews.apache.org/r/42674/diff/2/?file=1218677#file1218677line351>
> >
> >     Instead of naked strings we should reuse a constant that we can change in one place.

I think I'll punt on this for now.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review116064
-----------------------------------------------------------


On Jan. 25, 2016, 7:18 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7. Docker daemon is reporting too many routes/links after downloading busybox, which is exactly the issue referred in the previous link.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review116064
-----------------------------------------------------------




src/tests/health_check_tests.cpp (line 351)
<https://reviews.apache.org/r/42674/#comment177079>

    Instead of naked strings we should reuse a constant that we can change in one place.


- Bernd Mathiske


On Jan. 22, 2016, 5:26 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review116162
-----------------------------------------------------------


Ship it!




Ship It!

- Isabel Jimenez


On Jan. 25, 2016, 7:18 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7. Docker daemon is reporting too many routes/links after downloading busybox, which is exactly the issue referred in the previous link.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review116149
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Jan. 25, 2016, 7:18 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2016, 7:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7. Docker daemon is reporting too many routes/links after downloading busybox, which is exactly the issue referred in the previous link.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/
-----------------------------------------------------------

(Updated Jan. 25, 2016, 7:18 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.


Repository: mesos


Description (updated)
-------

Replaced busybox with alpine in docker tests.
Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7. Docker daemon is reporting too many routes/links after downloading busybox, which is exactly the issue referred in the previous link.
Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.


Diffs
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
  src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 

Diff: https://reviews.apache.org/r/42674/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Timothy Chen <tn...@apache.org>.

> On Jan. 23, 2016, 5:40 p.m., Jie Yu wrote:
> > Can you add more context in the description? Is that because there are too many links in busybox, causing issues with docker with brfts backend snce brfts backend has a limit on links?
> > 
> > Also, can you do a sweep in the code base to make sure there's no 'busybox' anymore?
> 
> Guangya Liu wrote:
>     Per Tim's above comment, he only wants to fix the test cases which are pulling or using the busybox image itself but not some reference, such as https://github.com/apache/mesos/blob/master/src/tests/containerizer/provisioner_docker_tests.cpp#L93 etc
> 
> Bernd Mathiske wrote:
>     Why not use "alpine" in the reference-only cases as well?
> 
> Guangya Liu wrote:
>     Agree, it would be good to use "alpine" in all places to keep consistent.

I'm not inclined in changing the reference only cases, since it's a valid image to use and we include other information from busybox in other cases to test parsing imaging, etc. We switch to Alpine only because the actual filesystem image is causing problems with the docker daemon in some configurations.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115992
-----------------------------------------------------------


On Jan. 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Guangya Liu <gy...@gmail.com>.

> On 一月 23, 2016, 5:40 p.m., Jie Yu wrote:
> > Can you add more context in the description? Is that because there are too many links in busybox, causing issues with docker with brfts backend snce brfts backend has a limit on links?
> > 
> > Also, can you do a sweep in the code base to make sure there's no 'busybox' anymore?

Per Tim's above comment, he only wants to fix the test cases which are pulling or using the busybox image itself but not some reference, such as https://github.com/apache/mesos/blob/master/src/tests/containerizer/provisioner_docker_tests.cpp#L93 etc


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115992
-----------------------------------------------------------


On 一月 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated 一月 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Guangya Liu <gy...@gmail.com>.

> On 一月 23, 2016, 5:40 p.m., Jie Yu wrote:
> > Can you add more context in the description? Is that because there are too many links in busybox, causing issues with docker with brfts backend snce brfts backend has a limit on links?
> > 
> > Also, can you do a sweep in the code base to make sure there's no 'busybox' anymore?
> 
> Guangya Liu wrote:
>     Per Tim's above comment, he only wants to fix the test cases which are pulling or using the busybox image itself but not some reference, such as https://github.com/apache/mesos/blob/master/src/tests/containerizer/provisioner_docker_tests.cpp#L93 etc
> 
> Bernd Mathiske wrote:
>     Why not use "alpine" in the reference-only cases as well?

Agree, it would be good to use "alpine" in all places to keep consistent.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115992
-----------------------------------------------------------


On 一月 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated 一月 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Bernd Mathiske <be...@mesosphere.io>.

> On Jan. 23, 2016, 9:40 a.m., Jie Yu wrote:
> > Can you add more context in the description? Is that because there are too many links in busybox, causing issues with docker with brfts backend snce brfts backend has a limit on links?
> > 
> > Also, can you do a sweep in the code base to make sure there's no 'busybox' anymore?
> 
> Guangya Liu wrote:
>     Per Tim's above comment, he only wants to fix the test cases which are pulling or using the busybox image itself but not some reference, such as https://github.com/apache/mesos/blob/master/src/tests/containerizer/provisioner_docker_tests.cpp#L93 etc

Why not use "alpine" in the reference-only cases as well?


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115992
-----------------------------------------------------------


On Jan. 22, 2016, 5:26 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115992
-----------------------------------------------------------



Can you add more context in the description? Is that because there are too many links in busybox, causing issues with docker with brfts backend snce brfts backend has a limit on links?

Also, can you do a sweep in the code base to make sure there's no 'busybox' anymore?

- Jie Yu


On Jan. 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/#review115996
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42674]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 23, 2016, 1:26 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42674/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 1:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced busybox with alpine in docker tests.
> Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
> Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
>   src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 
> 
> Diff: https://reviews.apache.org/r/42674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42674/
-----------------------------------------------------------

(Updated Jan. 23, 2016, 1:26 a.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu.


Repository: mesos


Description
-------

Replaced busybox with alpine in docker tests.
Busybox is currently causing issues with Docker daemon with btrfs backed (https://github.com/docker/docker/issues/16755), which is the default on CentOS 7.
Tested CentOS and Ubuntu 14.04 with alpine and all Docker tests passed.


Diffs (updated)
-----

  src/tests/containerizer/docker_containerizer_tests.cpp 81ab3625a69644d9659d484f3c605aaa5a10b397 
  src/tests/containerizer/docker_tests.cpp 9583070d64e96f5a57db62b3fb69073ecc5b502b 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/hook_tests.cpp 152984b01069acd4cf195bfce58835f0304a97f2 

Diff: https://reviews.apache.org/r/42674/diff/


Testing
-------

make check


Thanks,

Timothy Chen