Re: [PR] Decouple Committer from Kafka and Enable Custom Coordinator Election [iceberg]

["bryanck (via GitHub)" <gi...@apache.org>]

bryanck commented on code in PR #12460:
URL: https://github.com/apache/iceberg/pull/12460#discussion_r2042358521


##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/CommitterFactory.java:
##########
@@ -18,11 +18,32 @@
  */
 package org.apache.iceberg.connect;
 
-import org.apache.iceberg.connect.channel.CommitterImpl;
+import org.apache.iceberg.common.DynConstructors;
 
 class CommitterFactory {
   static Committer createCommitter(IcebergSinkConfig config) {
-    return new CommitterImpl();
+    String committerImpl = config.committerImpl();
+    DynConstructors.Ctor<Committer> ctor;
+    try {

Review Comment:
   You can combine these try blocks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org