[GitHub] [incubator-superset] micimize commented on issue #8303: Tabs in dashboard columns

[GitBox <gi...@apache.org>]

micimize commented on issue #8303: Tabs in dashboard columns
URL: https://github.com/apache/incubator-superset/issues/8303#issuecomment-536205589
 
 
   @mistercrunch dashboards. Tabs on `master` can only be top-level or nested within other tabs, and I'm proposing allowing deeper/less constrained nesting for building layouts such as:
   
   ![tabs in column](https://user-images.githubusercontent.com/8343799/65819528-72b80880-e1e3-11e9-9f61-6287ccf2762f.gif)
   
   Here's a compressed diff of my current changes to `superset/assets/src/dashboard/util/isValidChild.js` (would of course refine the depth limits in an actual PR):
   ```diff
   const parentMaxDepthLookup = {
      // ...
      [DASHBOARD_GRID_TYPE]: {
   -    [TABS_TYPE]: depthOne,
   +    [TABS_TYPE]: depthFive,
      },
      // ...
      [TABS_TYPE]: {
   -    [TAB_TYPE]: depthTwo,
   +    [TAB_TYPE]: depthFive,
      },
   
      [TAB_TYPE]: {
   -    [TABS_TYPE]: depthTwo,
   +    [TABS_TYPE]: depthThree,
      },
   
      [COLUMN_TYPE]: {
        // ...
   +    [TABS_TYPE]: depthFive,
      },
      // ...
   }
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org