You are viewing a plain text version of this content. The canonical link for it is here.

Posted to hdfs-issues@hadoop.apache.org by "Kihwal Lee (JIRA)" <ji...@apache.org> on 2014/05/16 12:31:13 UTC

[jira] [Commented] (HDFS-6402) Suppress findbugs warning for failure to override equals and hashCode in FsAclPermission.

    [ https://issues.apache.org/jira/browse/HDFS-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998853#comment-13998853 ] 

Kihwal Lee commented on HDFS-6402:
----------------------------------

+1 I tried {{mvn compile findbugs:findbugs}} and the patch does remove the warning.

> Suppress findbugs warning for failure to override equals and hashCode in FsAclPermission.
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-6402
>                 URL: https://issues.apache.org/jira/browse/HDFS-6402
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.4.1
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Trivial
>             Fix For: 3.0.0, 2.4.1
>
>         Attachments: HDFS-6402.1.patch
>
>
> HDFS-6326 introduced the {{FsAclPermission}} class as a subclass of {{FsPermission}}.  This triggered a findbugs warning due to not overriding {{equals}} and {{hashCode}}.  It's intentional that these methods are not overridden.  We can override them to call {{super.equals}} and {{super.hashCode}} to suppress the findbugs warning.



--
This message was sent by Atlassian JIRA
(v6.2#6252)