You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2008/08/12 06:14:25 UTC
svn commit: r685030 - in /hadoop/hbase/trunk: CHANGES.txt
src/java/org/apache/hadoop/hbase/regionserver/HStore.java
Author: stack
Date: Mon Aug 11 21:14:24 2008
New Revision: 685030
URL: http://svn.apache.org/viewvc?rev=685030&view=rev
Log:
HBASE-812 Compaction needs little better skip algo
Modified:
hadoop/hbase/trunk/CHANGES.txt
hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HStore.java
Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=685030&r1=685029&r2=685030&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Mon Aug 11 21:14:24 2008
@@ -16,6 +16,7 @@
HBASE-801 When a table haven't disable, shell could response in a "user
friendly" way.
HBASE-816 TableMap should survive USE (Andrew Purtell via Stack)
+ HBASE-812 Compaction needs little better skip algo (Daniel Leffel via Stack)
NEW FEATURES
OPTIMIZATIONS
Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HStore.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HStore.java?rev=685030&r1=685029&r2=685030&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HStore.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/HStore.java Mon Aug 11 21:14:24 2008
@@ -784,10 +784,19 @@
}
filesToCompact = new ArrayList<HStoreFile>(filesToCompact.subList(point,
countOfFiles));
+ if (filesToCompact.size() <= 1) {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Skipped compaction of 1 file; compaction size of " +
+ this.storeNameStr + ": " +
+ StringUtils.humanReadableInt(totalSize) + "; Skipped " + point +
+ " files, size: " + skipped);
+ }
+ return checkSplit();
+ }
if (LOG.isDebugEnabled()) {
LOG.debug("Compaction size of " + this.storeNameStr + ": " +
- StringUtils.humanReadableInt(totalSize) + ", skipped " + point +
- ", " + skipped);
+ StringUtils.humanReadableInt(totalSize) + "; Skipped " + point +
+ " files , size: " + skipped);
}
}