You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2018/04/20 01:50:32 UTC

[incubator-servicecomb-java-chassis] 08/09: SCB-483 delete unnecessary type cast

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-java-chassis.git

commit 5ea3718cceee1d9d6b01e66abd4170fe2ba201a6
Author: wujimin <wu...@huawei.com>
AuthorDate: Wed Apr 18 00:25:25 2018 +0800

    SCB-483 delete unnecessary type cast
---
 .../org/apache/servicecomb/common/javassist/TestJavassistUtils.java   | 4 ++--
 .../apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java  | 2 +-
 .../servicecomb/common/rest/definition/path/PathVarParamWriter.java   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java b/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java
index 73c4c7f..a69eb0f 100644
--- a/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java
+++ b/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java
@@ -152,7 +152,7 @@ public class TestJavassistUtils {
   public void multiWrapper() throws Exception {
     ClassConfig classConfig = new ClassConfig();
     classConfig.setClassName("cse.ut.multi.Wrapper");
-    classConfig.addField("intField", (Type) int.class);
+    classConfig.addField("intField", int.class);
     classConfig.addField("strField", String.class);
 
     JavassistUtils.genMultiWrapperInterface(classConfig);
@@ -161,7 +161,7 @@ public class TestJavassistUtils {
 
     MultiWrapper instance = (MultiWrapper) wrapperClass.newInstance();
     instance.writeFields(new Object[] {100, "test"});
-    Object[] fieldValues = (Object[]) instance.readFields();
+    Object[] fieldValues = instance.readFields();
     Assert.assertEquals(100, fieldValues[0]);
     Assert.assertEquals("test", fieldValues[1]);
   }
diff --git a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java
index f1c985f..8fd1e89 100644
--- a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java
+++ b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java
@@ -178,7 +178,7 @@ public final class ProtobufSchemaUtils {
     return getOrCreateSchema(type, () -> {
       if (!isArgsNeedWrap(method)) {
         // 可以直接使用
-        Class<?> cls = (Class<?>) method.getParameterTypes()[0];
+        Class<?> cls = method.getParameterTypes()[0];
         Schema<?> schema = RuntimeSchema.createFrom(cls);
         return WrapSchemaFactory.createSchema(schema, WrapType.ARGS_NOT_WRAP);
       }
diff --git a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriter.java b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriter.java
index c38b038..95659e8 100644
--- a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriter.java
+++ b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriter.java
@@ -29,6 +29,6 @@ public class PathVarParamWriter extends AbstractUrlParamWriter {
 
   @Override
   public void write(StringBuilder builder, Object[] args) throws Exception {
-    builder.append((Object) getParamValue(args));
+    builder.append(getParamValue(args));
   }
 }

-- 
To stop receiving notification emails like this one, please contact
liubao@apache.org.