You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jflatow <gi...@git.apache.org> on 2014/07/26 05:07:49 UTC
[GitHub] cordova-plugin-contacts pull request: fix a nasty memory leak on i...
GitHub user jflatow opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/35
fix a nasty memory leak on ios
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/quasiconvex/cordova-plugin-contacts master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit d28ba9013cae21abc6826a1d6dbd06d841874c1d
Author: Jared Flatow <jf...@gmail.com>
Date: 2014-07-26T03:06:00Z
fix a nasty memory leak on ios
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts issue #35: fix a nasty memory leak on ios
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/35
@lboekhorst see #132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: fix a nasty memory leak on i...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/35#issuecomment-55631636
The CFRetain there is correct since we do want to keep a reference to the record. The memory leak still occurs however, since we don't have a dealloc in the class to handle the CFRelease of the record.
This pull request should be closed, and the "add a search limit" feature should be sent as a separate PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-contacts issue #35: fix a nasty memory leak on ios
Posted by lboekhorst <gi...@git.apache.org>.
Github user lboekhorst commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/35
@shazron was the dealloc ever implemented? I am also having this issue, and https://github.com/apache/cordova-plugin-contacts/pull/35/commits/d28ba9013cae21abc6826a1d6dbd06d841874c1d fixes it, but from your comment I understand this is not the proper way to do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: fix a nasty memory leak on i...
Posted by skrosoft <gi...@git.apache.org>.
Github user skrosoft commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/35#issuecomment-199899458
Hi, I still have a memory problem with 2.0.1 version. Each time I call the find() function, memory is acumulating the results, after calling the find method 1500 times, my IPhone crash because the APP is using more than 1GB of ram memory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: fix a nasty memory leak on i...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/35#issuecomment-52059543
Please file a bug per http://wiki.apache.org/cordova/IssueWorkflow
also, `a nasty memory leak` doesn't tell me anything. It'd be helpful if you at least indicated the rough condition that triggers the leak. It looks like it's "fix memory leak in `CDVContact::setRecord`"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---