[GitHub] [airflow] vandonr-amz commented on a diff in pull request #30948: Add deferrable mode to AWS glue operators (Job & Crawl)

["vandonr-amz (via GitHub)" <gi...@apache.org>]

vandonr-amz commented on code in PR #30948:
URL: https://github.com/apache/airflow/pull/30948#discussion_r1180715737


##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -603,7 +603,7 @@ def get_client_type(
         """Get the underlying boto3 client using boto3 session"""
         client_type = self.client_type
         session = self.get_session(region_name=region_name, deferrable=deferrable)
-        if not isinstance(session, boto3.session.Session):
+        if isinstance(session, AioSession):

Review Comment:
   doing this is technically equivalent, but with the positive match, the IDE "understands" the type we're expecting, and provides auto-completion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org