[GitHub] [rocketmq] cserwen commented on a diff in pull request #4523: [ISSUE #4522] Fix topic route info not found in some case

[GitBox <gi...@apache.org>]

cserwen commented on code in PR #4523:
URL: https://github.com/apache/rocketmq/pull/4523#discussion_r911564678


##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java:
##########
@@ -240,6 +240,13 @@ public RemotingCommand registerBrokerWithFilterServer(ChannelHandlerContext ctx,
             registerBrokerBody.getFilterServerList(),
             ctx.channel());
 
+        if (result == null) {

Review Comment:
   ```java
   if (topicConfigWrapper.getTopicConfigTable().size() == 1) {
       log.warn("Can't register topicConfigWrapper={} because broker={} has not registered.", topicConfigWrapper, brokerName);
       return null; 
   }
   ```
   
   `null` is returned directly. @Oliverwqcwrw 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org