You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@fluss.apache.org by "Jackeyzhe (via GitHub)" <gi...@apache.org> on 2026/10/12 12:51:42 UTC

Re: [PR] [build] Relocate shaded jackson and other internal deps in fluss-fs-s3 [fluss]

Jackeyzhe commented on PR #4073:
URL: https://github.com/apache/fluss/pull/4073#issuecomment-6124628523

   Gentle ping @fresh-borzoni for review when you have a moment.
   
   CI is green and the branch is CLEAN against `main`. One note on the review
   state: @binary-signal approved this on 2026-08-28, but that approval is
   anchored at `a742c136` — the commit a later force-push replaced — so it now
   reads as outdated against the current head (`f240912f`). A fresh look would
   help.
   
   The change is confined to `fluss-fs-s3/pom.xml` (+116/-6): it merges the shade
   relocations into a single `<relocations>` block, narrows the broad
   `com.google` / `org.apache.commons` / `org.codehaus` patterns down to the
   packages this jar actually bundles, and excludes the
   `META-INF/versions/**/com/fasterxml/**` entries that the shade plugin leaves
   at their original package path (the same issue class as #3553).
   
   Happy to rebase or adjust anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org