You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/01/23 11:57:13 UTC
Review Request 42684: Multiple Disk: Added persistent volumes tests
for `MOUNT` type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9
src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124631
-----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (line 153)
<https://reviews.apache.org/r/42684/#comment187255>
This should be `1u` to avoid a compilation error with GCC5+.
- Neil Conway
On March 21, 2016, 1:42 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 1:42 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made volume sizes consistent with disk sizes to conform with `MOUNT`
> requirements.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
> src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review125062
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 21, 2016, 1:42 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 1:42 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made volume sizes consistent with disk sizes to conform with `MOUNT`
> requirements.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
> src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated March 21, 2016, 1:42 p.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191
Repository: mesos
Description (updated)
-------
Made volume sizes consistent with disk sizes to conform with `MOUNT`
requirements.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated March 21, 2016, 10:37 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191
Repository: mesos
Description (updated)
-------
Multiple Disk: Added persistent volumes tests for `MOUNT` type.
Made volume sizes consistent with disk sizes to conform with `MOUNT`
requirements.
Diffs
-----
src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124373
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 42593, 42505, 42506, 42684]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 18, 2016, 10:46 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 10:46 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
> src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124499
-----------------------------------------------------------
It would be great to have a unit test that verifies that when a task using a `MOUNT` volume exceeds the disk space on the volume, the task gets an error on the disk write, which it can then handle as appropriate (this is important behavior for some use-cases of the `MOUNT` feature). This test might be out of scope for this RR -- let me know if you'd like me to open a JIRA.
- Neil Conway
On March 18, 2016, 10:46 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 10:46 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
> src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated March 18, 2016, 10:46 p.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191
Repository: mesos
Description
-------
Multiple Disk: Added persistent volumes tests for `MOUNT` type.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review116453
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 42593, 42505, 42506, 42684]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 26, 2016, 8:20 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 8:20 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
> src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On March 17, 2016, 11:31 p.m., Neil Conway wrote:
> >
Thanks for the review!
> On March 17, 2016, 11:31 p.m., Neil Conway wrote:
> > src/tests/persistent_volume_tests.cpp, line 152
> > <https://reviews.apache.org/r/42684/diff/5/?file=1221796#file1221796line152>
> >
> > Personally I would find this clearer if the order of operands was reversed, e.g., `CHECK_GE(id, 1)`
I agree. I wanted to write it that way, but it would void the `expected, actual` policy. I chose to stick with consistency in this case.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124120
-----------------------------------------------------------
On March 21, 2016, 10:37 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated March 21, 2016, 10:37 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
>
> Made volume sizes consistent with disk sizes to conform with `MOUNT`
> requirements.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967
> src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review124120
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/persistent_volume_tests.cpp (line 152)
<https://reviews.apache.org/r/42684/#comment186503>
Personally I would find this clearer if the order of operands was reversed, e.g., `CHECK_GE(id, 1)`
src/tests/persistent_volume_tests.cpp (line 204)
<https://reviews.apache.org/r/42684/#comment186504>
`constexpr`? And name this `NUM_DISKS`?
src/tests/persistent_volume_tests.cpp (line 229)
<https://reviews.apache.org/r/42684/#comment186501>
Typo ("privileges")
src/tests/persistent_volume_tests.cpp (line 290)
<https://reviews.apache.org/r/42684/#comment186502>
Can you add a comment (e.g., to commit message) why you're changing all these disk resources sizes to be larger?
- Neil Conway
On Jan. 26, 2016, 8:20 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 8:20 p.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
> src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 8:20 p.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
fixed non-linux compilation issue.
Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191
Repository: mesos
Description
-------
Multiple Disk: Added persistent volumes tests for `MOUNT` type.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated Jan. 26, 2016, 7:49 p.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
Updated for non-linux build.
Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191
Repository: mesos
Description
-------
Multiple Disk: Added persistent volumes tests for `MOUNT` type.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review116006
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 42593, 42505, 42506, 42684]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 24, 2016, 1:33 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 1:33 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9
> src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated Jan. 24, 2016, 1:33 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191
Repository: mesos
Description
-------
Multiple Disk: Added persistent volumes tests for `MOUNT` type.
Diffs
-----
src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9
src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated Jan. 24, 2016, 1:08 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Repository: mesos
Description
-------
Multiple Disk: Added persistent volumes tests for `MOUNT` type.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9
src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
-----------------------------------------------------------
(Updated Jan. 24, 2016, 1:02 a.m.)
Review request for mesos, Jie Yu and Michael Park.
Changes
-------
made a `tmpfs` mount instead of relying on an existing one.
Used an integral id for the different disks.
Repository: mesos
Description (updated)
-------
Multiple Disk: Added persistent volumes tests for `MOUNT` type.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9
src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
Diff: https://reviews.apache.org/r/42684/diff/
Testing
-------
sudo make check
Thanks,
Joris Van Remoortere
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review115985
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 42593, 42505, 42506, 42684]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 23, 2016, 10:57 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 10:57 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9
> src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 42684: Multiple Disk: Added persistent volumes
tests for `MOUNT` type.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review115991
-----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (line 90)
<https://reviews.apache.org/r/42684/#comment177028>
Add a new line above.
src/tests/persistent_volume_tests.cpp (line 92)
<https://reviews.apache.org/r/42684/#comment177029>
add a new line above
src/tests/persistent_volume_tests.cpp (lines 97 - 110)
<https://reviews.apache.org/r/42684/#comment177027>
Hum, this looks a little hacky to me. /sys/fs/cgroup is a tmpfs as well. Are we going to write random file in it?
We can mount a tmpfs to diskPath (but we need to clean it up in TearDown).
src/tests/persistent_volume_tests.cpp (line 141)
<https://reviews.apache.org/r/42684/#comment177030>
Can you add a comment here explaining what 'number' is? Also, I prefer to call it 'name' like 'disk1', 'disk2', etc.
- Jie Yu
On Jan. 23, 2016, 10:57 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2016, 10:57 a.m.)
>
>
> Review request for mesos, Jie Yu and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9
> src/tests/resources_tests.cpp b42610f1bf8eacfd7bf388d351f8745f1d96f666
>
> Diff: https://reviews.apache.org/r/42684/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Joris Van Remoortere
>
>