[GitHub] [helix] jiajunwang commented on issue #520: Refactoring soft constraints to simply the algorithm and fix potential issues.

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #520: Refactoring soft constraints to simply the algorithm and fix potential issues.
URL: https://github.com/apache/helix/pull/520#issuecomment-545285793
 
 
   > @jiajunwang Also from now on, please try to keep PRs separate. Structural changes could go in one PR, and logic change could go in another. I know it's just tempting and feels faster to do everything in one, but this PR clearly has gotten too big. I'll discuss with you offline to clear up some confusion.
   
   I agree with that in principle. But it is not always true in real life. If you notice, all my changes focusing on the same component. And they are highly related. If I split the change, there would be 2 problems.
   1. I need to make some intermediate test changes for each split PR. Not only wasting of the dev time but also wasting of the reviewing time.
   2. The reviewer could be confused about why a change is necessary when they are separate.
   
   Last but not least, the algorithm is complicated. I don't think I can split the PR without breaking things in a reasonable time. So I think for this case, separating is not worthwhile.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org