[GitHub] [incubator-pegasus] neverchanje commented on a change in pull request #601: feat(hotspot): add a function to start hotkey detecting in hotspot_partition_calculator

[GitBox <gi...@apache.org>]

neverchanje commented on a change in pull request #601:
URL: https://github.com/apache/incubator-pegasus/pull/601#discussion_r489126115



##########
File path: src/server/hotspot_partition_calculator.h
##########
@@ -37,6 +51,10 @@ class hotspot_partition_calculator
     void data_aggregate(const std::vector<row_data> &partitions);
     // analyse the saved data to find hotspot partition
     void data_analyse();
+    static void send_hotkey_detect_request(const std::string &app_name,

Review comment:
       Where this function is used? Should it be private? If it's public, why don't make it a free function outside from `hotspot_partition_calculator`?
   
   ```
   class hotspot_partition_calculator {
   };
   
   extern  void send_hotkey_detect_request(...
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org