You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/09/13 03:48:05 UTC
[kudu-CR] build-and-test: only run cmake once
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4401
to review the following change.
Change subject: build-and-test: only run cmake once
......................................................................
build-and-test: only run cmake once
Running it twice as we were before was confusing, and the way in which we'd
override BUILD_TYPE was error-prone (e.g. the ASAN-specific check for
disabling core dumps was broken).
Change-Id: I8f9eb27d69ac4d120a0bdad1d1695b4f59b12641
---
M build-support/jenkins/build-and-test.sh
1 file changed, 38 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/4401/1
--
To view, visit http://gerrit.cloudera.org:8080/4401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f9eb27d69ac4d120a0bdad1d1695b4f59b12641
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build-and-test: only run cmake once
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: build-and-test: only run cmake once
......................................................................
build-and-test: only run cmake once
Running it twice as we were before was confusing, and the way in which we'd
override BUILD_TYPE was error-prone (e.g. the ASAN-specific check for
disabling core dumps was broken).
Change-Id: I8f9eb27d69ac4d120a0bdad1d1695b4f59b12641
Reviewed-on: http://gerrit.cloudera.org:8080/4401
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 38 insertions(+), 21 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f9eb27d69ac4d120a0bdad1d1695b4f59b12641
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] build-and-test: only run cmake once
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: build-and-test: only run cmake once
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f9eb27d69ac4d120a0bdad1d1695b4f59b12641
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] build-and-test: only run cmake once
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: build-and-test: only run cmake once
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3400/
--
To view, visit http://gerrit.cloudera.org:8080/4401
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f9eb27d69ac4d120a0bdad1d1695b4f59b12641
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No