You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/01 18:13:31 UTC

[GitHub] [shardingsphere] abhinav-koppula opened a new pull request, #21308: [Issue #21016]-Improve coverage of BootstrapArguments

abhinav-koppula opened a new pull request, #21308:
URL: https://github.com/apache/shardingsphere/pull/21308

   Fixes #21016 .
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #21308: [Issue #21016]-Improve coverage of BootstrapArguments

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21308:
URL: https://github.com/apache/shardingsphere/pull/21308#issuecomment-1264452360

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21308?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21308](https://codecov.io/gh/apache/shardingsphere/pull/21308?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1d23819) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e0d9ce4704bd2485e6896992f4a0bcb4ab779d87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0d9ce4) will **decrease** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #21308      +/-   ##
   ============================================
   - Coverage     61.62%   61.62%   -0.01%     
     Complexity     2500     2500              
   ============================================
     Files          4085     4085              
     Lines         56483    56483              
     Branches       7504     7504              
   ============================================
   - Hits          34808    34805       -3     
   - Misses        18756    18758       +2     
   - Partials       2919     2920       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...fig/swapper/mode/YamlModeConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/21308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL21vZGUvWWFtbE1vZGVDb25maWd1cmF0aW9uU3dhcHBlci5qYXZh) | `45.45% <0.00%> (-4.55%)` | :arrow_down: |
   | [...ervice/config/global/GlobalRulePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9nbG9iYWwvR2xvYmFsUnVsZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | `23.07% <0.00%> (-4.20%)` | :arrow_down: |
   | [...ler/distsql/ral/queryable/ShowModeInfoHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93TW9kZUluZm9IYW5kbGVyLmphdmE=) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
   | [...mespace/parser/DataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/21308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctbmFtZXNwYWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvbmFtZXNwYWNlL3BhcnNlci9EYXRhU291cmNlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `87.50% <0.00%> (-0.60%)` | :arrow_down: |
   | [.../mode/metadata/persist/MetaDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9NZXRhRGF0YVBlcnNpc3RTZXJ2aWNlLmphdmE=) | `65.11% <0.00%> (ø)` | |
   | [...ervice/config/global/PropertiesPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9nbG9iYWwvUHJvcGVydGllc1BlcnNpc3RTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...dingsphere/proxy/arguments/BootstrapArguments.java](https://codecov.io/gh/apache/shardingsphere/pull/21308/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9hcmd1bWVudHMvQm9vdHN0cmFwQXJndW1lbnRzLmphdmE=) | `94.44% <0.00%> (+5.55%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] terrymanu merged pull request #21308: [Issue #21016]-Improve coverage of BootstrapArguments

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21308:
URL: https://github.com/apache/shardingsphere/pull/21308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org