You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/04/15 10:02:20 UTC
[PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
rickyma opened a new pull request, #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647
### What changes were proposed in this pull request?
Remove meaningless string concatenation.
### Why are the changes needed?
Better readablity and performance, and reduce maintenance complexity.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2058719446
We hope the description could be attached in the commit log when you operate `squal and commit` button. @EnricoMi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2058811667
> You mean the description of the pull request?
Like this:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "EnricoMi (via GitHub)" <gi...@apache.org>.
EnricoMi commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2058722361
You mean the description of the pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2056478312
## Test Results
2 339 files - 24 2 339 suites - 24 4h 14m 57s :stopwatch: - 15m 29s
882 tests - 30 881 :white_check_mark: - 30 1 :zzz: ±0 0 :x: ±0
10 525 runs - 60 10 511 :white_check_mark: - 60 14 :zzz: ±0 0 :x: ±0
Results for commit 2d7d052f. ± Comparison against base commit 6ea43002.
<details>
<summary>This pull request <b>removes</b> 30 tests.</summary>
```
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCombineBuffer
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testCommitBlocksWhenMemoryShuffleDisabled
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testOnePartition
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteException
org.apache.hadoop.mapred.SortWriteBufferManagerTest ‑ testWriteNormal
org.apache.hadoop.mapred.SortWriteBufferTest ‑ testReadWrite
org.apache.hadoop.mapreduce.RssMRUtilsTest ‑ applyDynamicClientConfTest
org.apache.hadoop.mapreduce.RssMRUtilsTest ‑ baskAttemptIdTest
org.apache.hadoop.mapreduce.RssMRUtilsTest ‑ blockConvertTest
org.apache.hadoop.mapreduce.RssMRUtilsTest ‑ partitionIdConvertBlockTest
…
```
</details>
[test-results]:data:application/gzip;base64,H4sIABcAHWYC/03Myw6DIBCF4VcxrLvgIoh9mcYOTEKq0nBZNX33jkasy/Mx/B+GYfaZ3Tup1HjrWK6hXLeraSohriRCy3EgoveyXVgr23rkCrCT+NMrvLdfJ+AUZgJ+gk8ppkNSXbem4FrqY7YomRCnHdW+waW672sU4rKEQoNJNzhKo+2tQa6egNA7L6zR3niuHAfE0UzAvj/jI4LFEgEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "EnricoMi (via GitHub)" <gi...@apache.org>.
EnricoMi commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2056757490
Is this exhaustive? Are this all instances of pointless string concatenations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "EnricoMi (via GitHub)" <gi...@apache.org>.
EnricoMi merged PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "EnricoMi (via GitHub)" <gi...@apache.org>.
EnricoMi commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2059236914
Sorry for that! This should be configured as the default squash behaviour then, no copy-paste required:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2056772159
> Is this exhaustive? Are this all instances of pointless string concatenations?
I think so, the string I searched for is `" + "`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma closed pull request #1647: [MINOR] Remove meaningless string concatenation
URL: https://github.com/apache/incubator-uniffle/pull/1647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [MINOR] Remove meaningless string concatenation [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1647:
URL: https://github.com/apache/incubator-uniffle/pull/1647#issuecomment-2058098202
Could you help merge this? @EnricoMi , I think you have permission to operate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org