You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/08/10 19:33:02 UTC
Review Request 61572: Made `killNestedContainer()` use `kill()` on the
containerizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61572/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
Instead of invoking `destroy()` directly, `killNestedContainer()`
would invoke `kill()` to terminate the nested container.
Diffs
-----
src/slave/http.cpp 2d33f0b498c8c819d1aaa6b39ae38b1009fda3e4
Diff: https://reviews.apache.org/r/61572/diff/1/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61572: Made `killNestedContainer()` use `kill()`
on the containerizer.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61572/#review182909
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 14, 2017, 5:20 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61572/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 5:20 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of invoking `destroy()` directly, `killNestedContainer()`
> would invoke `kill()` to terminate the nested container.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 2d33f0b498c8c819d1aaa6b39ae38b1009fda3e4
>
>
> Diff: https://reviews.apache.org/r/61572/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61572: Made `killNestedContainer()` use `kill()`
on the containerizer.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61572/#review182899
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 14, 2017, 5:20 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61572/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 5:20 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of invoking `destroy()` directly, `killNestedContainer()`
> would invoke `kill()` to terminate the nested container.
>
>
> Diffs
> -----
>
> src/slave/http.cpp 2d33f0b498c8c819d1aaa6b39ae38b1009fda3e4
>
>
> Diff: https://reviews.apache.org/r/61572/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61572: Made `killNestedContainer()` use `kill()`
on the containerizer.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61572/
-----------------------------------------------------------
(Updated Aug. 14, 2017, 5:20 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Changed `Optional` to `int` for `signal` variable.
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
Instead of invoking `destroy()` directly, `killNestedContainer()`
would invoke `kill()` to terminate the nested container.
Diffs (updated)
-----
src/slave/http.cpp 2d33f0b498c8c819d1aaa6b39ae38b1009fda3e4
Diff: https://reviews.apache.org/r/61572/diff/2/
Changes: https://reviews.apache.org/r/61572/diff/1-2/
Testing
-------
make check
Thanks,
Anand Mazumdar