You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/02 09:28:13 UTC

[GitHub] [flink] twalthr commented on a change in pull request #16053: [FLINK-22847][sql-client] Quote options when using SET;

twalthr commented on a change in pull request #16053:
URL: https://github.com/apache/flink/pull/16053#discussion_r643769036



##########
File path: flink-table/flink-sql-client/src/test/resources/sql/misc.q
##########
@@ -30,9 +30,9 @@ HELP		Prints the available commands.
 INSERT INTO		Inserts the results of a SQL SELECT query into a declared table sink.
 INSERT OVERWRITE		Inserts the results of a SQL SELECT query into a declared table sink and overwrite existing data.
 QUIT		Quits the SQL CLI client.
-RESET		Resets a session configuration property. Syntax: 'RESET <key>;'. Use 'RESET;' for reset all session properties.
+RESET		Resets a session configuration property. Syntax: 'RESET '<key>';'. Use 'RESET;' for reset all session properties.

Review comment:
       Let's change them to double quotes. It is just explanatory text.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org