You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2024/03/04 21:56:56 UTC
[PR] fix bug with like filter on missing columns not correctly considering extractionFn (druid)
clintropolis opened a new pull request, #16037:
URL: https://github.com/apache/druid/pull/16037
### Description
Fixes a bug with `LikeFilter` that can occur when using an `extractionFn` that replaces null values with non-null values, such as a lookup with replace missing values set, and then querying a segment with a missing column. In this case, the query would incorrectly check if the like-matcher matched `null` instead of applying the `extractionFn` which might change `null` to not, and choose the incorrect index for the case.
The added test models this case, and fails without the changes to `LikeFilter`.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix bug with like filter on missing columns not correctly considering extractionFn (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis commented on PR #16037:
URL: https://github.com/apache/druid/pull/16037#issuecomment-1977617885
not sure what the failing CI docs thing is all about, seems unrelated to changes here:
```
Error: Invalid docusaurus-theme-mermaid version 2.4.3.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] fix bug with like filter on missing columns not correctly considering extractionFn (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #16037:
URL: https://github.com/apache/druid/pull/16037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org