You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/13 13:19:49 UTC
[GitHub] [pinot] richardstartin opened a new pull request, #8531: open javac modules for google-java-format
richardstartin opened a new pull request, #8531:
URL: https://github.com/apache/pinot/pull/8531
Google-java-format is JK17 incompatible, having dependencies on Javac internals, so needs some modules exported to run on JDK17. See more here: https://github.com/google/google-java-format/issues/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
richardstartin commented on PR #8531:
URL: https://github.com/apache/pinot/pull/8531#issuecomment-1098504912
@xiangfu0 it builds. I will revert the dummy commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on code in PR #8531:
URL: https://github.com/apache/pinot/pull/8531#discussion_r849864582
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,14 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
Review Comment:
Just add a newline in pom.xml should trigger it. You can revert it back once the test is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on a diff in pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
richardstartin commented on code in PR #8531:
URL: https://github.com/apache/pinot/pull/8531#discussion_r849882427
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,14 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
Review Comment:
running now
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,14 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
Review Comment:
running now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on code in PR #8531:
URL: https://github.com/apache/pinot/pull/8531#discussion_r849865322
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,15 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: >
+ -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25
Review Comment:
indentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
xiangfu0 merged PR #8531:
URL: https://github.com/apache/pinot/pull/8531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on code in PR #8531:
URL: https://github.com/apache/pinot/pull/8531#discussion_r849797357
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,14 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
Review Comment:
is this multi-line with backslash the correct format?
or you can try this one:
```
MAVEN_OPTS: >
-Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25
-Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on a diff in pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
richardstartin commented on code in PR #8531:
URL: https://github.com/apache/pinot/pull/8531#discussion_r849852754
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,14 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
Review Comment:
good catch. how do I force it to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on code in PR #8531:
URL: https://github.com/apache/pinot/pull/8531#discussion_r849797357
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,14 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
Review Comment:
is this multi-line with backslash the correct format?
```
MAVEN_OPTS: >
-Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25
-Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on a diff in pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on code in PR #8531:
URL: https://github.com/apache/pinot/pull/8531#discussion_r849798789
##########
.github/workflows/pinot_compatibility_tests.yml:
##########
@@ -48,7 +48,14 @@ jobs:
NEW_COMMIT: ${{ github.event.inputs.newCommit }}
WORKING_DIR: /tmp/compatibility-verifier
TEST_SUITE: ${{ matrix.test_suite }}
- MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 -Dmaven.wagon.http.retryHandler.count=3 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
+ MAVEN_OPTS: -Xmx2G -DskipShade -DfailIfNoTests=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=25 \
Review Comment:
You may also need to modify the script a bit to let it trigger the job once to kick off the action tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on PR #8531:
URL: https://github.com/apache/pinot/pull/8531#issuecomment-1098505345
> @xiangfu0 it builds. I will revert the dummy commit.
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #8531: open javac modules for google-java-format
Posted by GitBox <gi...@apache.org>.
richardstartin commented on PR #8531:
URL: https://github.com/apache/pinot/pull/8531#issuecomment-1098505300
https://github.com/apache/pinot/runs/6014542400?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org