You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by DrIgor <gi...@git.apache.org> on 2016/12/19 10:52:11 UTC

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

GitHub user DrIgor opened a pull request:

    https://github.com/apache/zeppelin/pull/1782

    [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure

    ### What is this PR for?
    Fix possible reason of DepInterpreterTest failure
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1782
    
----
commit a2af13583f0f5be975e9f1780140d683a66d3983
Author: Igor Drozdov <ig...@epam.com>
Date:   2016-12-19T10:00:39Z

    Fix possible reason of DepInterpreterTest failure
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:

    https://github.com/apache/zeppelin/pull/1782

    [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure

    ### What is this PR for?
    Fix possible reason of DepInterpreterTest failure
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1782
    
----
commit a2af13583f0f5be975e9f1780140d683a66d3983
Author: Igor Drozdov <ig...@epam.com>
Date:   2016-12-19T10:00:39Z

    Fix possible reason of DepInterpreterTest failure
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1782
  
    LGTM and merge to master 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/1782
  
    Ping?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:

    https://github.com/apache/zeppelin/pull/1782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/1782
  
    @bzz @1ambda I attached CI logs
    
    Failures are:
    * `ZeppelinIT.testAngularDisplay:157->AbstractZeppelinIT.waitForText:84 � StaleElementReference`
    * `AngularElemTest:`
      `AngularElem`
      - `should provide onclick method *** FAILED ***`
        `The code passed to eventually never returned normally. Attempted 1 times over 359.286866 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:64)`
    * `RemoteSchedulerTest.test:150 expected:<0> but was:<1>`
    * `InterpreterIT.testShowDescriptionOnInterpreterCreate:69 � ElementNotVisible Element is not currently visible and so may not be interacted with`
    * `AngularElemTest:`
      `AngularElem`
      - `should provide onclick method *** FAILED ***`
        `The code passed to eventually never returned normally. Attempted 1 times over 198.575701 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:64)`
    
    Seems to be unrelated to dependency resolution


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/1782
  
    Those are other flaky tests already reported. You can search JIRA [here](https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20and%20text%20~%20%22testShowDescriptionOnInterpreterCreate%22)
    
    Thanks for triggering CI multiple times. 
    Regarding to your question, i am also not sure. But if i were a travis CI developer, i wouldn't create new CI build if there is already connected, running one. (it's just my guess)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:

    https://github.com/apache/zeppelin/pull/1782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:

    https://github.com/apache/zeppelin/pull/1782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/1782
  
    Thanks for fixing a flaky test :) 
    
    It would be great if you accumulate CI multiple results like #1667 for review. Just closing and re-opening will also works instead of pushing the ammended commit multiple times
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:

    https://github.com/apache/zeppelin/pull/1782

    [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure

    ### What is this PR for?
    Fix possible reason of DepInterpreterTest failure
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1782
    
----
commit a2af13583f0f5be975e9f1780140d683a66d3983
Author: Igor Drozdov <ig...@epam.com>
Date:   2016-12-19T10:00:39Z

    Fix possible reason of DepInterpreterTest failure
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/1782
  
    Could you file CI links? :) also


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor commented on the issue:

    https://github.com/apache/zeppelin/pull/1782
  
    @1ambda yes, of course
    
    * https://travis-ci.org/apache/zeppelin/builds/185383249
    * https://travis-ci.org/apache/zeppelin/builds/185389810
    * https://travis-ci.org/apache/zeppelin/builds/185398627
    
    I'm new to travis. Should I wait until build completed before reopening pull request again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:

    https://github.com/apache/zeppelin/pull/1782

    [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure

    ### What is this PR for?
    Fix possible reason of DepInterpreterTest failure
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1782
    
----
commit a2af13583f0f5be975e9f1780140d683a66d3983
Author: Igor Drozdov <ig...@epam.com>
Date:   2016-12-19T10:00:39Z

    Fix possible reason of DepInterpreterTest failure
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:

    https://github.com/apache/zeppelin/pull/1782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:

    https://github.com/apache/zeppelin/pull/1782

    [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure

    ### What is this PR for?
    Fix possible reason of DepInterpreterTest failure
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1782
    
----
commit a2af13583f0f5be975e9f1780140d683a66d3983
Author: Igor Drozdov <ig...@epam.com>
Date:   2016-12-19T10:00:39Z

    Fix possible reason of DepInterpreterTest failure
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
GitHub user DrIgor reopened a pull request:

    https://github.com/apache/zeppelin/pull/1782

    [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure

    ### What is this PR for?
    Fix possible reason of DepInterpreterTest failure
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1782
    
----
commit a2af13583f0f5be975e9f1780140d683a66d3983
Author: Igor Drozdov <ig...@epam.com>
Date:   2016-12-19T10:00:39Z

    Fix possible reason of DepInterpreterTest failure
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...

Posted by DrIgor <gi...@git.apache.org>.
Github user DrIgor closed the pull request at:

    https://github.com/apache/zeppelin/pull/1782


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---