You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jason-ong <gi...@git.apache.org> on 2015/08/21 11:37:29 UTC
[GitHub] cordova-plugin-file-transfer pull request: Add in default value fo...
GitHub user jason-ong opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/98
Add in default value for fileName & mimeType
To match the FileUpload documentation for IOS ,
change fileName default value to "image.jpg"
change mimeType default value to "image/jpg"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jason-ong/cordova-plugin-file-transfer master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 4f7cdc28a8f68a4f3723b111bd797743ab1a788e
Author: jason-ong <ja...@gmail.com>
Date: 2015-08-21T09:35:42Z
Add in default value for fileName & mimeType
To match the documentation for FileUpload,
change fileName default value to "image.jpg"
change mimeType default value to "image/jpg"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...
Posted by jason-ong <gi...@git.apache.org>.
Github user jason-ong commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/98#issuecomment-147752585
@daserge done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Add in default value fo...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/98#issuecomment-147694794
Created a [Jira issue](https://issues.apache.org/jira/browse/CB-9790);
@jason-ong, could you please rename the PR title and commit title to `CB-9790 Align FileUploadOptions fileName and mimeType default parameter values to the docs on iOS`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/98#issuecomment-148428651
Looks like `mimeType` default in JS will break the Windows case:
https://github.com/apache/cordova-plugin-file-transfer/blob/1142a96b2ce281fcc11b914dc21fac01eb446d9e/src/windows/FileTransferProxy.js#L109
So it is better to leave it as is probably at least for this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9790 Align FileUploa...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/98#issuecomment-148422624
@jason-ong, thanks!
I've looked into the PR once more - I believe it will be better to default these values on JS side:
https://github.com/apache/cordova-plugin-file-transfer/blob/1142a96b2ce281fcc11b914dc21fac01eb446d9e/www/FileTransfer.js#L122-L123
We could also default `fileKey` to `'file'` and `chunkedMode` to `true`.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org