You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Svet <no...@github.com> on 2015/05/12 10:26:17 UTC

[jclouds] Make home folder globally accessible when creating a user (#746)

Certain hardened images will have `umask 0077` set for the root user, making the newly created `/home/users` folder inaccessible to non-root. This results in a failure when trying to ssh with the new account. Explicitly set permissions to be independent of default umask.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/746

-- Commit Summary --

  * Make home folder globally accessible when creating a user

-- File Changes --

    M compute/src/test/java/org/jclouds/compute/callables/RunScriptOnNodeUsingSshTest.java (4)
    M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/login/UserAdd.java (5)
    M scriptbuilder/src/test/java/org/jclouds/scriptbuilder/statements/login/UserAddTest.java (20)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/746.patch
https://github.com/jclouds/jclouds/pull/746.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/746

Re: [jclouds] Make home folder globally accessible when creating a user (#746)

Posted by Svet <no...@github.com>.

Updated PR, local tests passing.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/746#issuecomment-101772489

Re: [jclouds] Make home folder globally accessible when creating a user (#746)

Posted by Ignasi Barrera <no...@github.com>.

Thanks @neykov!

I was about to merge this but there are test failures in the [StubComputeServiceIntegrationTest](https://github.com/jclouds/jclouds/blob/master/compute/src/test/java/org/jclouds/compute/StubComputeServiceIntegrationTest.java) (our CI only runs the unit tests, not the integration ones):

    Tests run: 40, Failures: 3, Errors: 0, Skipped: 11

Could you kindly fix them, and make sure a `mvn clean install` passes all tests? Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/746#issuecomment-101327810

Re: [jclouds] Make home folder globally accessible when creating a user (#746)

Posted by Ignasi Barrera <no...@github.com>.

Closed #746.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/746#event-304303723

Re: [jclouds] Make home folder globally accessible when creating a user (#746)

Posted by Ignasi Barrera <no...@github.com>.

Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3bdac1cc) and [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/caae63b9). Thanks @neykov!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/746#issuecomment-101816144