Re: [PATCH] Disallow passing None for revision arguments in svn.client

[Jelmer Vernooij <je...@samba.org>]

On Wed, 2006-06-14 at 11:27 -0400, Garrett Rooney wrote:
> On 6/14/06, Jelmer Vernooij <je...@samba.org> wrote:
> > Trivial patch for svn.client's Python bindings.
> >
> > [[[
> >
> >  * subversion/bindings/swig/svn_client.i:
> >    Disallow passing NULL revision and peg_revision arguments.
> >
> > ]]]
> What happens if you try to pass NULL?  Is this something we can test?
You'll get a SIGSEGV. With this patch, you'll get a ValueError exception
instead of a crash.

Cheers,

Jelmer
-- 
Jelmer Vernooij <je...@samba.org> - http://samba.org/~jelmer/

Re: [PATCH] Disallow passing None for revision arguments in svn.client

[Garrett Rooney <ro...@electricjellyfish.net>]

On 6/14/06, Jelmer Vernooij <je...@samba.org> wrote:

> You'll get a SIGSEGV. With this patch, you'll get a ValueError exception
> instead of a crash.

That sounds a lot nicer ;-)

Committed in r20095.

A patch adding tests for this functionality would certainly be
appreciated, but plugging the segfault hole seems like a good first
step.

Thanks,

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org