You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2011/01/31 23:09:29 UTC

[jira] Reopened: (LUCENE-2831) Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context

     [ https://issues.apache.org/jira/browse/LUCENE-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir reopened LUCENE-2831:
---------------------------------


There are some issues here with IndexSearcher, mostly found with LUCENE-2751 (once we started randomly using the executor service in tests).
# some recursion bugs in IndexSearcher(IndexReader r, boolean closeReader, ExecutorService executor)
# i noticed problems with IndexSearcher(ReaderContext topLevel, AtomicReaderContext... leaves), the varargs causes this ctor to become ambiguous with other ctors (such as ReaderContext, ExecutorService). I don't understand why this ctor needs to be public, i noticed Solr's QueryValueSource is the only thing using it, and I think instead that should be fixed.

> Revise Weight#scorer & Filter#getDocIdSet API to pass Readers context
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-2831
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2831
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-2831-nuke-SolrIndexReader.patch, LUCENE-2831-nuke-SolrIndexReader.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831.patch, LUCENE-2831_transition_to_atomicCtx.patch, LUCENE-2831_transition_to_atomicCtx.patch, LUCENE-2831_transition_to_atomicCtx.patch
>
>
> Spinoff from LUCENE-2694 - instead of passing a reader into Weight#scorer(IR, boolean, boolean) we should / could revise the API and pass in a struct that has parent reader, sub reader, ord of that sub. The ord mapping plus the context with its parent would make several issues way easier. See LUCENE-2694, LUCENE-2348 and LUCENE-2829 to name some.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org