You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/29 10:19:37 UTC
[GitHub] [inlong] woofyzhao opened a new pull request, #6064: [INLONG-6063][Manager] Utilize ClickHouse and Iceberg data node
woofyzhao opened a new pull request, #6064:
URL: https://github.com/apache/inlong/pull/6064
- Fixes #6063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on pull request #6064: [INLONG-6063][Manager] Utilize ClickHouse and Iceberg data node
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on PR #6064:
URL: https://github.com/apache/inlong/pull/6064#issuecomment-1264566665
> I suggest add description about modifying hive
Done. See the third modification desc above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6064: [INLONG-6063][Manager] Utilize ClickHouse and Iceberg data node
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6064:
URL: https://github.com/apache/inlong/pull/6064#discussion_r983420274
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/iceberg/IcebergResourceOperator.java:
##########
@@ -78,11 +87,27 @@ public void createSinkResource(SinkInfo sinkInfo) {
this.createTable(sinkInfo);
}
+ private IcebergSinkDTO getIcebergInfo(SinkInfo sinkInfo) {
+ IcebergSinkDTO icebergInfo = IcebergSinkDTO.getFromJson(sinkInfo.getExtParams());
+
+ // read uri from data node if not supplied by user
+ if (StringUtils.isBlank(icebergInfo.getCatalogUri())
+ && icebergInfo.getCatalogType().equals(CATALOG_TYPE_HIVE)) {
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6064: [INLONG-6063][Manager] Utilize ClickHouse and Iceberg data node
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6064:
URL: https://github.com/apache/inlong/pull/6064#discussion_r983419010
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/iceberg/IcebergSinkOperator.java:
##########
@@ -83,6 +87,15 @@ public StreamSink getFromEntity(StreamSinkEntity entity) {
}
IcebergSinkDTO dto = IcebergSinkDTO.getFromJson(entity.getExtParams());
+ if (StringUtils.isBlank(dto.getCatalogUri()) && dto.getCatalogType().equals(CATALOG_TYPE_HIVE)) {
Review Comment:
Suggest changing `dto.getCatalogType().equals(CATALOG_TYPE_HIVE)` to `CATALOG_TYPE_HIVE.equals(dto.getCatalogType())`.
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sink/iceberg/IcebergSinkOperator.java:
##########
@@ -83,6 +87,15 @@ public StreamSink getFromEntity(StreamSinkEntity entity) {
}
IcebergSinkDTO dto = IcebergSinkDTO.getFromJson(entity.getExtParams());
+ if (StringUtils.isBlank(dto.getCatalogUri()) && dto.getCatalogType().equals(CATALOG_TYPE_HIVE)) {
Review Comment:
Suggest changing `dto.getCatalogType().equals(CATALOG_TYPE_HIVE)` to `CATALOG_TYPE_HIVE.equals(dto.getCatalogType())` to avoid NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #6064: [INLONG-6063][Manager] Utilize ClickHouse and Iceberg data node
Posted by GitBox <gi...@apache.org>.
gong commented on PR #6064:
URL: https://github.com/apache/inlong/pull/6064#issuecomment-1263087389
I suggest add description about modifying hive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org