code readability and JavaDoc

[Mark Struberg <st...@yahoo.de>]

Hiho!

Just a quick bid: 

fn(Annotation... annotations) {...}

is not the most descriptive parameter naming ;)
Would also help if we write a quick JavaDoc for such functions.

I'm currently (still) reworking the whole Observer to ObserverMethod.
Sorry for taking so long, but I have not looked at that piece of code for a long time and only have a few spare hours per week currently.

Btw, what shall we do with our 'reformatted'  ASL headers?
I used the default ASL headers in the atinject-api, and hopefully fixed all headers in the webbeans-api. But webbeans-impl and the plugins imho still needs fixing. Should we?

LieGrue,
strub


      

Re: code readability and JavaDoc

[Gurkan Erdogdu <cg...@gmail.com>]

+1 for documentation.

I think that we can fix header formatting later on. But if you wish do it :)

Thanks;

--Gurkan

2009/10/20 Mark Struberg <st...@yahoo.de>

> Hiho!
>
> Just a quick bid:
>
> fn(Annotation... annotations) {...}
>
> is not the most descriptive parameter naming ;)
> Would also help if we write a quick JavaDoc for such functions.
>
> I'm currently (still) reworking the whole Observer to ObserverMethod.
> Sorry for taking so long, but I have not looked at that piece of code for a
> long time and only have a few spare hours per week currently.
>
> Btw, what shall we do with our 'reformatted'  ASL headers?
> I used the default ASL headers in the atinject-api, and hopefully fixed all
> headers in the webbeans-api. But webbeans-impl and the plugins imho still
> needs fixing. Should we?
>
> LieGrue,
> strub
>
>
>
>


-- 
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com